Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Unified Diff: content/public/common/common_param_traits.cc

Issue 1153763002: Hardening the 'url::Origin' implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/websocket_bridge.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/common_param_traits.cc
diff --git a/content/public/common/common_param_traits.cc b/content/public/common/common_param_traits.cc
index 7ed8236b13450a1d31cd39e84dcc6f44e79bcf08..76c9866cab357184a195f43b82cd8128f8fa0394 100644
--- a/content/public/common/common_param_traits.cc
+++ b/content/public/common/common_param_traits.cc
@@ -54,25 +54,29 @@ void ParamTraits<GURL>::Log(const GURL& p, std::string* l) {
l->append(p.spec());
}
-void ParamTraits<url::Origin>::Write(Message* m,
- const url::Origin& p) {
- m->WriteString(p.string());
+void ParamTraits<url::Origin>::Write(Message* m, const url::Origin& p) {
+ WriteParam(m, p.scheme());
+ WriteParam(m, p.host());
+ WriteParam(m, p.port());
}
bool ParamTraits<url::Origin>::Read(const Message* m,
PickleIterator* iter,
url::Origin* p) {
- std::string s;
- if (!iter->ReadString(&s)) {
+ std::string scheme;
+ std::string host;
+ uint16 port;
+ if (!ReadParam(m, iter, &scheme) || !ReadParam(m, iter, &host) ||
+ !ReadParam(m, iter, &port)) {
*p = url::Origin();
return false;
}
- *p = url::Origin(s);
+ *p = url::Origin(scheme, host, port);
return true;
}
void ParamTraits<url::Origin>::Log(const url::Origin& p, std::string* l) {
- l->append(p.string());
+ l->append(p.serialize());
}
void ParamTraits<net::HostPortPair>::Write(Message* m, const param_type& p) {
« no previous file with comments | « content/child/websocket_bridge.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698