net/websockets/websocket_stream.cc - Issue 1153763002: Hardening the 'url::Origin' implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_stream.cc

Issue 1153763002: Hardening the 'url::Origin' implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/websockets/websocket_stream.cc

diff --git a/net/websockets/websocket_stream.cc b/net/websockets/websocket_stream.cc

index e818b5489158825c4241958a2bc1169d0e99f80c..9226764f99af66d68b84959f99524bf07101eba1 100644

--- a/net/websockets/websocket_stream.cc

+++ b/net/websockets/websocket_stream.cc

@@ -94,7 +94,7 @@ class StreamRequestImpl : public WebSocketStreamRequest {

HttpRequestHeaders headers;

headers.SetHeader(websockets::kUpgrade, websockets::kWebSocketLowercase);

headers.SetHeader(HttpRequestHeaders::kConnection, websockets::kUpgrade);

- headers.SetHeader(HttpRequestHeaders::kOrigin, origin.string());

+ headers.SetHeader(HttpRequestHeaders::kOrigin, origin.serialize());

headers.SetHeader(websockets::kSecWebSocketVersion,

websockets::kSupportedVersion);

url_request_->SetExtraRequestHeaders(headers);