Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 1153723010: Remove page/EventHandler.* and fix core.gypi (Closed)

Created:
4 years, 10 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, kochi
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove page/EventHandler.* and fix core.gypi EventHandler.cpp and .h have been copied by crrev.com/1148813007 from page directory to input directory, and those in page remain. This CL removes those in page and fixes core.gypi. BUG=496757 TEST=n/a Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4614 lines) Patch
M Source/core/core.gypi View 2 chunks +2 lines, -1 line 0 comments Download
D Source/core/page/EventHandler.h View 1 chunk +0 lines, -434 lines 0 comments Download
D Source/core/page/EventHandler.cpp View 1 chunk +0 lines, -4179 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hajimehoshi
PTAL
4 years, 10 months ago (2015-06-08 04:45:48 UTC) #2
kochi
lgtm
4 years, 10 months ago (2015-06-08 04:47:47 UTC) #4
tkent
lgtm
4 years, 10 months ago (2015-06-08 04:50:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153723010/1
4 years, 10 months ago (2015-06-08 05:24:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=196649
4 years, 10 months ago (2015-06-08 05:43:14 UTC) #8
Rick Byers
On 2015/06/08 05:43:14, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 10 months ago (2015-06-08 14:02:44 UTC) #9
lanwei
On 2015/06/08 14:02:44, Rick Byers wrote: > On 2015/06/08 05:43:14, commit-bot: I haz the power ...
4 years, 10 months ago (2015-06-08 15:31:29 UTC) #10
hajimehoshi
4 years, 10 months ago (2015-06-10 04:41:48 UTC) #11
Message was sent while issue was closed.
On 2015/06/08 15:31:29, lanwei wrote:
> On 2015/06/08 14:02:44, Rick Byers wrote:
> > On 2015/06/08 05:43:14, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > > https://src.chromium.org/viewvc/blink?view=rev&revision=196649
> > 
> > Thank you very much for quickly fixing this!  We obviously should have
caught
> > these issues in the original CL, sorry!
> 
> Thank you very much for fixing my mistake, and I am very sorry about it.

No problem :-)

Powered by Google App Engine
This is Rietveld 408576698