Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 1153723008: Don't create an AXScrollView for a FrameView that's about to be deleted. (Closed)

Created:
4 years, 11 months ago by dmazzoni
Modified:
4 years, 11 months ago
Reviewers:
je_julie(Not used)
CC:
blink-reviews, je_julie, nektarios, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't create an AXScrollView for a FrameView that's about to be deleted. BUG=490505, 481730 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196462

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add more comments based on review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -2 lines) Patch
A LayoutTests/accessibility/event-on-deleted-iframe-causes-crash.html View 1 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/event-on-deleted-iframe-causes-crash-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dmazzoni
4 years, 11 months ago (2015-06-03 21:45:25 UTC) #2
je_julie(Not used)
lgtm! https://codereview.chromium.org/1153723008/diff/1/LayoutTests/accessibility/event-on-deleted-iframe-causes-crash.html File LayoutTests/accessibility/event-on-deleted-iframe-causes-crash.html (right): https://codereview.chromium.org/1153723008/diff/1/LayoutTests/accessibility/event-on-deleted-iframe-causes-crash.html#newcode23 LayoutTests/accessibility/event-on-deleted-iframe-causes-crash.html:23: <script> nit; In the beginning, I didn't understand ...
4 years, 11 months ago (2015-06-04 01:48:43 UTC) #3
dmazzoni
https://codereview.chromium.org/1153723008/diff/1/LayoutTests/accessibility/event-on-deleted-iframe-causes-crash.html File LayoutTests/accessibility/event-on-deleted-iframe-causes-crash.html (right): https://codereview.chromium.org/1153723008/diff/1/LayoutTests/accessibility/event-on-deleted-iframe-causes-crash.html#newcode23 LayoutTests/accessibility/event-on-deleted-iframe-causes-crash.html:23: <script> On 2015/06/04 01:48:43, je_julie wrote: > nit; In ...
4 years, 11 months ago (2015-06-04 03:29:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153723008/20001
4 years, 11 months ago (2015-06-04 03:30:36 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 06:09:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196462

Powered by Google App Engine
This is Rietveld 408576698