Issue 1153673005: Make Uri.base work in SkyView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153673005: Make Uri.base work in SkyView (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
eseidel

CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	sky/engine/bindings/builtin_natives.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	sky/engine/core/frame/LocalDOMWindow.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/script/dart_controller.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/script/dart_controller.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sky/engine/core/script/dom_dart_state.h	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	sky/engine/core/script/dom_dart_state.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/public/sky/sky_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 6 months ago (2015-06-04 00:00:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0a342ce009767371f1bc1b60f5783ee3e17e9635 (presubmit successful).