Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1153673003: Make delete API consistent for String objects (Closed)

Created:
5 years, 7 months ago by conradw
Modified:
5 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make delete API consistent for String objects Deleting an in-bounds character index from a String object should always return false. BUG= LOG=N Committed: https://crrev.com/d62425b5dfcc2d1b6cdfde97fff28a4d19c75e09 Cr-Commit-Position: refs/heads/master@{#28592}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
conradw
PTAL
5 years, 7 months ago (2015-05-22 12:34:59 UTC) #3
rossberg
lgtm
5 years, 7 months ago (2015-05-22 12:43:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153673003/20001
5 years, 7 months ago (2015-05-22 12:51:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-22 13:09:18 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 13:09:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d62425b5dfcc2d1b6cdfde97fff28a4d19c75e09
Cr-Commit-Position: refs/heads/master@{#28592}

Powered by Google App Engine
This is Rietveld 408576698