Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1153653003: Use SequencedSocketData in SpdySessionTest. (Closed)

Created:
5 years, 6 months ago by Bence
Modified:
5 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SequencedSocketData in SpdySessionTest. * Use SequencedSocketData instead of DeterministicSocketData in SpdySessionTest. * Use nullptr instead of NULL, EXPECT_FALSE() instead of EXPECT_EQ(nullptr), etc. * Uniformly use RunLoop() instead of MessageLoop::current(). * Remove unnecessary set_connect_data calls. BUG=492698 Committed: https://crrev.com/273d29cdbe3be5f49e104e67192926dbcac358c1 Cr-Commit-Position: refs/heads/master@{#333122}

Patch Set 1 #

Patch Set 2 : Convert SessionFlowControlNoSendLeaks. #

Patch Set 3 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+873 lines, -941 lines) Patch
M net/spdy/spdy_session_unittest.cc View 1 2 229 chunks +873 lines, -941 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 6 months ago (2015-06-05 18:10:11 UTC) #2
Ryan Hamilton
YES!!!! lgtm
5 years, 6 months ago (2015-06-05 20:29:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153653003/40001
5 years, 6 months ago (2015-06-05 20:40:28 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-05 20:46:47 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:47:50 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/273d29cdbe3be5f49e104e67192926dbcac358c1
Cr-Commit-Position: refs/heads/master@{#333122}

Powered by Google App Engine
This is Rietveld 408576698