chrome/browser/ui/views/extensions/extension_popup_aura.cc - Issue 1153633006: Added UMA statistics for changing the active window via click or touch events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_popup_aura.cc

Issue 1153633006: Added UMA statistics for changing the active window via click or touch events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Polish and added unit tests. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/extensions/extension_popup_aura.cc

diff --git a/chrome/browser/ui/views/extensions/extension_popup_aura.cc b/chrome/browser/ui/views/extensions/extension_popup_aura.cc

index e3e7c909439c83437b801a6a9afe0c9258bbdb41..7901f3f2f7cfe70f472582db3833e966892808ca 100644

--- a/chrome/browser/ui/views/extensions/extension_popup_aura.cc

+++ b/chrome/browser/ui/views/extensions/extension_popup_aura.cc

@@ -53,8 +53,10 @@ void ExtensionPopupAura::OnWidgetDestroying(views::Widget* widget) {

}

-void ExtensionPopupAura::OnWindowActivated(aura::Window* gained_active,

- aura::Window* lost_active) {

+void ExtensionPopupAura::OnWindowActivated(

+ aura::client::ActivationChangeObserver::ActivationReason reason,

+ aura::Window* gained_active,

+ aura::Window* lost_active) {

// Close on anchor window activation (ie. user clicked the browser window).

// DesktopNativeWidgetAura does not trigger the expected browser widget

// [de]activation events when activating widgets in its own root window.

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_popup_aura.h ('k') | tools/metrics/actions/actions.xml » ('j') | ui/aura/window.cc » ('J')