Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: ash/metrics/task_switch_metrics_recorder.h

Issue 1153633006: Added UMA statistics for changing the active window via click or touch events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reworked approach to use the an ActivationChangeObserver. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_METRICS_TASK_SWITCH_METRIC_RECORDER_H_ 5 #ifndef ASH_METRICS_TASK_SWITCH_METRIC_RECORDER_H_
6 #define ASH_METRICS_TASK_SWITCH_METRIC_RECORDER_H_ 6 #define ASH_METRICS_TASK_SWITCH_METRIC_RECORDER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "ash/ash_export.h" 10 #include "ash/ash_export.h"
11 #include "base/containers/scoped_ptr_hash_map.h" 11 #include "base/containers/scoped_ptr_hash_map.h"
12 12
13 namespace aura {
14 class Window;
15 } // namespace aura
16
13 namespace ash { 17 namespace ash {
14 18
15 class TaskSwitchTimeTracker; 19 class TaskSwitchTimeTracker;
16 20
17 // The TaskSwitchMetricsRecorder class records UMA metrics related to task 21 // The TaskSwitchMetricsRecorder class records UMA metrics related to task
18 // switching. The main purpose of the TaskSwitchMetricsRecorder is to track time 22 // switching. The main purpose of the TaskSwitchMetricsRecorder is to track time
19 // deltas between task switches and record histograms of the deltas. 23 // deltas between task switches and record histograms of the deltas.
20 class ASH_EXPORT TaskSwitchMetricsRecorder { 24 class ASH_EXPORT TaskSwitchMetricsRecorder {
21 public: 25 public:
22 // Enumeration of the different user interfaces that could be the source of 26 // Enumeration of the different user interfaces that could be the source of
23 // a task switch. Note this is not necessarily comprehensive of all sources. 27 // a task switch. Note this is not necessarily comprehensive of all sources.
24 enum TaskSwitchSource { 28 enum TaskSwitchSource {
25 // Task switches from selecting items in the app list. 29 // Task switches from selecting items in the app list.
26 kAppList, 30 kAppList,
27 // Task switches caused by selecting a window from overview mode which is 31 // Task switches caused by selecting a window from overview mode which is
28 // different from the previously-active window. 32 // different from the previously-active window.
29 kOverviewMode, 33 kOverviewMode,
34 // Task switches caused by the user clicking or tapping a window in the
35 // 2-dimensional screen space.
36 kDesktop,
30 // All task switches caused by shelf buttons, not including sub-menus. 37 // All task switches caused by shelf buttons, not including sub-menus.
31 kShelf, 38 kShelf,
32 // All task switches caused by the tab strip. 39 // All task switches caused by the tab strip.
33 kTabStrip, 40 kTabStrip,
34 // Task switches caused by the WindowCycleController (ie Alt+Tab). 41 // Task switches caused by the WindowCycleController (ie Alt+Tab).
35 kWindowCycleController 42 kWindowCycleController
36 }; 43 };
37 44
38 TaskSwitchMetricsRecorder(); 45 TaskSwitchMetricsRecorder();
39 virtual ~TaskSwitchMetricsRecorder(); 46 virtual ~TaskSwitchMetricsRecorder();
40 47
41 // Notifies |this| that a "navigate to" task switch has occurred. A 48 // Notifies |this| that a "navigate to" task switch has occurred. A
42 // "navigate to" operation is defined by a task switch where the specific task 49 // "navigate to" operation is defined by a task switch where the specific task
43 // that becomes active is user-predictable (ie Alt+Tab accelerator, launching 50 // that becomes active is user-predictable (ie Alt+Tab accelerator, launching
44 // a new window via the shelf, etc). Contrast to a "navigate away" operation 51 // a new window via the shelf, etc). Contrast to a "navigate away" operation
45 // which is defined as a user interaction that navigates away from a specified 52 // which is defined as a user interaction that navigates away from a specified
46 // task and the next task that becomes active is likely not user-predictable 53 // task and the next task that becomes active is likely not user-predictable
47 // (ie. closing or minimizing a window, closing a tab, etc). 54 // (ie. closing or minimizing a window, closing a tab, etc).
48 // 55 //
49 // Will add an entry to |histogram_map_| when called for the first time for 56 // Will add an entry to |histogram_map_| when called for the first time for
50 // each |task_switch_source| value. 57 // each |task_switch_source| value.
51 void OnTaskSwitch(TaskSwitchSource task_switch_source); 58 void OnTaskSwitch(TaskSwitchSource task_switch_source);
52 59
60 // Returns true if |window| is considered a task window.
61 bool IsATaskWindow(aura::Window* window) const;
62
53 private: 63 private:
54 // Returns the TaskSwitchTimeTracker associated with the specified 64 // Returns the TaskSwitchTimeTracker associated with the specified
55 // |task_switch_source|. May return nullptr if mapping does not exist yet. 65 // |task_switch_source|. May return nullptr if mapping does not exist yet.
56 TaskSwitchTimeTracker* FindTaskSwitchTimeTracker( 66 TaskSwitchTimeTracker* FindTaskSwitchTimeTracker(
57 TaskSwitchSource task_switch_source); 67 TaskSwitchSource task_switch_source);
58 68
59 // Adds a TaskSwitchTimeTracker to |histogram_map_| for the specified 69 // Adds a TaskSwitchTimeTracker to |histogram_map_| for the specified
60 // |task_switch_source|. Behavior is undefined if a TaskSwitchTimeTracker 70 // |task_switch_source|. Behavior is undefined if a TaskSwitchTimeTracker
61 // |histogram_map_| already has an entry for |task_switch_source|. 71 // |histogram_map_| already has an entry for |task_switch_source|.
62 void AddTaskSwitchTimeTracker(TaskSwitchSource task_switch_source); 72 void AddTaskSwitchTimeTracker(TaskSwitchSource task_switch_source);
63 73
64 // Tracks TaskSwitchSource to TaskSwitchTimeTracker mappings. The 74 // Tracks TaskSwitchSource to TaskSwitchTimeTracker mappings. The
65 // |histogram_map_| is populated on demand the first time a 75 // |histogram_map_| is populated on demand the first time a
66 // TaskSwitchTimeTracker is needed for a given source. 76 // TaskSwitchTimeTracker is needed for a given source.
67 base::ScopedPtrHashMap<int, scoped_ptr<TaskSwitchTimeTracker>> histogram_map_; 77 base::ScopedPtrHashMap<int, scoped_ptr<TaskSwitchTimeTracker>> histogram_map_;
68 78
69 DISALLOW_COPY_AND_ASSIGN(TaskSwitchMetricsRecorder); 79 DISALLOW_COPY_AND_ASSIGN(TaskSwitchMetricsRecorder);
70 }; 80 };
71 81
72 } // namespace ash 82 } // namespace ash
73 83
74 #endif // ASH_METRICS_TASK_SWITCH_METRIC_RECORDER_H_ 84 #endif // ASH_METRICS_TASK_SWITCH_METRIC_RECORDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698