Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 115363004: Remove "AV Win7" bot. (Closed)

Created:
7 years ago by Nico
Modified:
7 years ago
CC:
chromium-reviews, cmp-cc_chromium.org, kkania
Visibility:
Public.

Description

Remove perf_av waterfall. Part of the pyauto removal. We migrated all perf_av tests to chromium.perf, and this waterfall is not of any use. BUG=224072 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=240945

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -358 lines) Patch
D build/masters/master.chromium.perf_av/Makefile View 1 1 chunk +0 lines, -5 lines 0 comments Download
D build/masters/master.chromium.perf_av/buildbot View 1 1 chunk +0 lines, -4 lines 0 comments Download
D build/masters/master.chromium.perf_av/buildbot.tac View 1 1 chunk +0 lines, -11 lines 0 comments Download
M build/masters/master.chromium.perf_av/master.cfg View 1 1 chunk +0 lines, -289 lines 0 comments Download
D build/masters/master.chromium.perf_av/master_site_config.py View 1 1 chunk +0 lines, -13 lines 0 comments Download
M build/masters/master.chromium.perf_av/slaves.cfg View 1 1 chunk +0 lines, -35 lines 0 comments Download
M build/tests/masters_test.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Nico
Red bot: http://build.chromium.org/p/chromium.perf_av/builders/AV%20Win7 It would make my life easier if the linux bot could go ...
7 years ago (2013-12-13 23:07:56 UTC) #1
Nico
https://codereview.chromium.org/115363004/diff/1/build/masters/master.chromium.perf_av/slaves.cfg File build/masters/master.chromium.perf_av/slaves.cfg (left): https://codereview.chromium.org/115363004/diff/1/build/masters/master.chromium.perf_av/slaves.cfg#oldcode29 build/masters/master.chromium.perf_av/slaves.cfg:29: 'hostname': 'chromeperf33', (btw, masters/master.chromium.unused is gone – is there ...
7 years ago (2013-12-13 23:09:09 UTC) #2
ghost stip (do not use)
buildbot lgtm, deferring to shadi whether this is the right move https://chromiumcodereview.appspot.com/115363004/diff/1/build/masters/master.chromium.perf_av/slaves.cfg File build/masters/master.chromium.perf_av/slaves.cfg (left): ...
7 years ago (2013-12-13 23:57:09 UTC) #3
ghost stip (do not use)
filed https://code.google.com/p/chromium/issues/detail?id=328601 to take care of unused bot
7 years ago (2013-12-14 01:21:49 UTC) #4
shadi1
thakis@: thanks for starting this, I've been delaying it for no reason. Can you actually ...
7 years ago (2013-12-16 18:11:14 UTC) #5
Nico
Done! Do I `make stop` for the master before landing this, to shut it down?
7 years ago (2013-12-16 18:21:19 UTC) #6
shadi
LGTM Thanks!
7 years ago (2013-12-16 18:31:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/115363004/10001
7 years ago (2013-12-16 18:40:19 UTC) #8
commit-bot: I haz the power
Presubmit check for 115363004-10001 failed and returned exit status 1. Running presubmit commit checks ...
7 years ago (2013-12-16 18:40:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/115363004/30001
7 years ago (2013-12-16 18:47:25 UTC) #10
commit-bot: I haz the power
7 years ago (2013-12-16 18:48:26 UTC) #11
Message was sent while issue was closed.
Change committed as 240945

Powered by Google App Engine
This is Rietveld 408576698