Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp - Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp ('K') | « Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp b/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp

index 17d780336ef945b7e0d031289d360219375cad54..720ed0bdef1035556ad8e81c0333d68b148a9e2e 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp

@@ -61,9 +61,8 @@ v8::Local<v8::Value> toV8(const TestInterfaceEventInit& impl, v8::Local<v8::Obje

bool toV8TestInterfaceEventInit(const TestInterfaceEventInit& impl, v8::Local<v8::Object> dictionary, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)

{

- // TODO(bashi): Use ForceSet() instead of Set(). http://crbug.com/476720

if (impl.hasStringMember()) {

- if (!v8CallBoolean(dictionary->Set(isolate->GetCurrentContext(), v8String(isolate, "stringMember"), v8String(isolate, impl.stringMember()))))

+ if (!v8CallBoolean(dictionary->CreateDataProperty(isolate->GetCurrentContext(), v8String(isolate, "stringMember"), v8String(isolate, impl.stringMember()))))

return false;

}