Source/bindings/core/v8/WindowProxy.cpp - Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/WindowProxy.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/V8ObjectBuilder.cpp ('k') | Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp » ('j') | Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/WindowProxy.cpp

diff --git a/Source/bindings/core/v8/WindowProxy.cpp b/Source/bindings/core/v8/WindowProxy.cpp

index 6374266650f27573d4734429b2c0bfacedfcb171..6f33b0a75c418e3edc89139b537873b9eba48aca 100644

--- a/Source/bindings/core/v8/WindowProxy.cpp

+++ b/Source/bindings/core/v8/WindowProxy.cpp

@@ -374,6 +374,8 @@ void WindowProxy::updateDocumentProperty()

checkDocumentWrapper(m_document.newLocal(m_isolate), frame->document());

ASSERT(documentWrapper->IsObject());

+ // We can't use DefineOwnProperty() here because it doesn't work for

+ // global proxy objects.

if (!v8CallBoolean(context->Global()->ForceSet(context, v8AtomicString(m_isolate, "document"), documentWrapper, static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontDelete))))

bashi 2015/06/03 00:16:37 We still need ForceSet().

return;