Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp - Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet()

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix uninitialized error Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

index 7e68cec02f23f4089edd95a4562b1f4ba5efc856..590f279738318e80cc49f73422166267c2745de7 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

@@ -30,10 +30,10 @@ const WrapperTypeInfo& TestInterfaceNamedConstructor::s_wrapperTypeInfo = V8Test

namespace TestInterfaceNamedConstructorV8Internal {

template<class CallbackInfo>

-static void TestInterfaceNamedConstructorForceSetAttributeOnThis(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info)

+static bool TestInterfaceNamedConstructorCreateDataProperty(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info)

{

ASSERT(info.This()->IsObject());

- v8::Local<v8::Object>::Cast(info.This())->ForceSet(info.GetIsolate()->GetCurrentContext(), name, v8Value);

+ return v8CallBoolean(v8::Local<v8::Object>::Cast(info.This())->CreateDataProperty(info.GetIsolate()->GetCurrentContext(), name, v8Value));

}

static void TestInterfaceNamedConstructorConstructorAttributeSetterCallback(v8::Local<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)

@@ -48,7 +48,7 @@ static void TestInterfaceNamedConstructorConstructorAttributeSetterCallback(v8::

const WrapperTypeInfo* wrapperTypeInfo = WrapperTypeInfo::unwrap(data);

if (!wrapperTypeInfo)

break;

- TestInterfaceNamedConstructorForceSetAttributeOnThis(v8String(info.GetIsolate(), wrapperTypeInfo->interfaceName), v8Value, info);

+ TestInterfaceNamedConstructorCreateDataProperty(v8String(info.GetIsolate(), wrapperTypeInfo->interfaceName), v8Value, info);

} while (false); // do ... while (false) just for use of break

TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

@@ -56,7 +56,7 @@ static void TestInterfaceNamedConstructorConstructorAttributeSetterCallback(v8::

static void testNamedConstructorConstructorAttributeAttributeSetter(v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)

{

v8::Local<v8::String> propertyName = v8AtomicString(info.GetIsolate(), "testNamedConstructorConstructorAttribute");

- TestInterfaceNamedConstructorForceSetAttributeOnThis(propertyName, v8Value, info);

+ TestInterfaceNamedConstructorCreateDataProperty(propertyName, v8Value, info);

}

static void testNamedConstructorConstructorAttributeAttributeSetterCallback(v8::Local<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)