Source/bindings/tests/results/core/V8TestInterface.cpp - Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet()

Unified Diff: Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix uninitialized error Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterface.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterface.cpp b/Source/bindings/tests/results/core/V8TestInterface.cpp

index 45552e8b108c58b35de1bd2adfe577a7e1a5dd80..85bb642e60f0c8aba99398593d8c29599a6595f8 100644

--- a/Source/bindings/tests/results/core/V8TestInterface.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterface.cpp

@@ -57,10 +57,10 @@ static void (*partial2VoidMethodMethodForPartialInterface)(const v8::FunctionCal

static void (*partial2StaticVoidMethodMethodForPartialInterface)(const v8::FunctionCallbackInfo<v8::Value>&) = 0;

template<class CallbackInfo>

-static void TestInterfaceImplementationForceSetAttributeOnThis(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info)

+static bool TestInterfaceImplementationCreateDataProperty(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info)

{

ASSERT(info.This()->IsObject());

- v8::Local<v8::Object>::Cast(info.This())->ForceSet(info.GetIsolate()->GetCurrentContext(), name, v8Value);

+ return v8CallBoolean(v8::Local<v8::Object>::Cast(info.This())->CreateDataProperty(info.GetIsolate()->GetCurrentContext(), name, v8Value));

}

static void TestInterfaceImplementationConstructorAttributeSetterCallback(v8::Local<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)

@@ -75,7 +75,7 @@ static void TestInterfaceImplementationConstructorAttributeSetterCallback(v8::Lo

const WrapperTypeInfo* wrapperTypeInfo = WrapperTypeInfo::unwrap(data);

if (!wrapperTypeInfo)

break;

- TestInterfaceImplementationForceSetAttributeOnThis(v8String(info.GetIsolate(), wrapperTypeInfo->interfaceName), v8Value, info);

+ TestInterfaceImplementationCreateDataProperty(v8String(info.GetIsolate(), wrapperTypeInfo->interfaceName), v8Value, info);

} while (false); // do ... while (false) just for use of break

TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

@@ -121,7 +121,7 @@ static void testInterfaceAttributeAttributeSetterCallback(const v8::FunctionCall

static void testInterfaceConstructorAttributeAttributeSetter(v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)

{

v8::Local<v8::String> propertyName = v8AtomicString(info.GetIsolate(), "testInterfaceConstructorAttribute");

- TestInterfaceImplementationForceSetAttributeOnThis(propertyName, v8Value, info);

+ TestInterfaceImplementationCreateDataProperty(propertyName, v8Value, info);

}

static void testInterfaceConstructorAttributeAttributeSetterCallback(v8::Local<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)