Source/bindings/core/v8/V8ObjectBuilder.cpp - Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8ObjectBuilder.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix uninitialized error Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8ObjectBuilder.cpp

diff --git a/Source/bindings/core/v8/V8ObjectBuilder.cpp b/Source/bindings/core/v8/V8ObjectBuilder.cpp

index e1aaf2cf498321460e3f22a9ce675fd1bd2dbce0..cba471c68bcf7cd1d9dcfab4bb031d1922cbae8b 100644

--- a/Source/bindings/core/v8/V8ObjectBuilder.cpp

+++ b/Source/bindings/core/v8/V8ObjectBuilder.cpp

@@ -54,7 +54,7 @@ void V8ObjectBuilder::addInternal(const String& name, v8::Local<v8::Value> value

{

if (m_object.IsEmpty())

return;

- if (value.IsEmpty() || m_object->ForceSet(m_scriptState->context(), v8String(m_scriptState->isolate(), name), value).IsNothing())

+ if (value.IsEmpty() || m_object->CreateDataProperty(m_scriptState->context(), v8String(m_scriptState->isolate(), name), value).IsNothing())

m_object.Clear();

}

« no previous file with comments | « Source/bindings/core/v8/V8LazyEventListener.cpp ('k') | Source/bindings/core/v8/WindowProxy.cpp » ('j') | no next file with comments »