| Index: Source/bindings/tests/results/core/V8TestObject.cpp
|
| diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp
|
| index 70e4e01aa0cec8a2978d401f1bd545033f3bbf06..5b87ef65b195789baa5e6fd0ffc0128a90dc82ba 100644
|
| --- a/Source/bindings/tests/results/core/V8TestObject.cpp
|
| +++ b/Source/bindings/tests/results/core/V8TestObject.cpp
|
| @@ -105,6 +105,7 @@ template<class CallbackInfo>
|
| static void TestObjectForceSetAttributeOnThis(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info)
|
| {
|
| ASSERT(info.This()->IsObject());
|
| + // TODO(bashi): Consider using CreateDataProperty() instead of ForceSet().
|
| v8::Local<v8::Object>::Cast(info.This())->ForceSet(info.GetIsolate()->GetCurrentContext(), name, v8Value);
|
| }
|
|
|
| @@ -13050,15 +13051,15 @@ void V8TestObject::preparePrototypeObject(v8::Isolate* isolate, v8::Local<v8::Ob
|
| unscopeables = prototypeObject->Get(v8Context, unscopablesSymbol).ToLocalChecked().As<v8::Object>();
|
| else
|
| unscopeables = v8::Object::New(isolate);
|
| - unscopeables->ForceSet(v8Context, v8AtomicString(isolate, "unscopeableLongAttribute"), v8::True(isolate)).FromJust();
|
| + unscopeables->CreateDataProperty(v8Context, v8AtomicString(isolate, "unscopeableLongAttribute"), v8::True(isolate)).FromJust();
|
| if (RuntimeEnabledFeatures::featureNameEnabled()) {
|
| - unscopeables->ForceSet(v8Context, v8AtomicString(isolate, "unscopeableRuntimeEnabledLongAttribute"), v8::True(isolate)).FromJust();
|
| + unscopeables->CreateDataProperty(v8Context, v8AtomicString(isolate, "unscopeableRuntimeEnabledLongAttribute"), v8::True(isolate)).FromJust();
|
| }
|
| if (RuntimeEnabledFeatures::featureNameEnabled()) {
|
| - unscopeables->ForceSet(v8Context, v8AtomicString(isolate, "unscopeableRuntimeEnabledVoidMethod"), v8::True(isolate)).FromJust();
|
| + unscopeables->CreateDataProperty(v8Context, v8AtomicString(isolate, "unscopeableRuntimeEnabledVoidMethod"), v8::True(isolate)).FromJust();
|
| }
|
| - unscopeables->ForceSet(v8Context, v8AtomicString(isolate, "unscopeableVoidMethod"), v8::True(isolate)).FromJust();
|
| - prototypeObject->ForceSet(v8Context, unscopablesSymbol, unscopeables).FromJust();
|
| + unscopeables->CreateDataProperty(v8Context, v8AtomicString(isolate, "unscopeableVoidMethod"), v8::True(isolate)).FromJust();
|
| + prototypeObject->CreateDataProperty(v8Context, unscopablesSymbol, unscopeables).FromJust();
|
| }
|
|
|
| void V8TestObject::refObject(ScriptWrappable* scriptWrappable)
|
|
|