Source/bindings/core/v8/custom/V8MessageEventCustom.cpp - Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp ('k') | Source/bindings/modules/v8/V8BindingForModules.cpp » ('j') | Source/bindings/templates/interface_base.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp b/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

index 0aa627841998361caebd724614aa0d84160467e3..d5908be8888123b8909a3a39492a6359c1d89f74 100644

--- a/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

@@ -98,6 +98,8 @@ void V8MessageEvent::dataAttributeGetterCustom(const v8::PropertyCallbackInfo<v8

// Overwrite the data attribute so it returns the cached result in future invocations.

// This custom getter handler will not be called again.

+ // TODO(bashi): Use CreateDataProperty() instead of ForceSet().

+ // http://crbug.com/475206

v8::PropertyAttribute dataAttr = static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly);

if (!v8CallBoolean(info.Holder()->ForceSet(info.GetIsolate()->GetCurrentContext(), v8AtomicString(info.GetIsolate(), "data"), result, dataAttr))) {

v8SetReturnValue(info, v8::Null(info.GetIsolate()));