Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: Source/bindings/core/v8/CustomElementConstructorBuilder.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
diff --git a/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp b/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
index 07d975284ae9837da236ef45e51f24ab02051288..82b3d341a33ed70a04b94516db9e857a6dcf13c6 100644
--- a/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
+++ b/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp
@@ -196,6 +196,8 @@ bool CustomElementConstructorBuilder::createConstructor(Document* document, Cust
// This *configures* the property. ForceSet of a function's
// "prototype" does not affect the value, but can reconfigure the
// property.
+ // TODO(bashi): Use CreateDataProperty() instead of ForceSet().
+ // http://crbug.com/475206
if (!v8CallBoolean(m_constructor->ForceSet(context, prototypeKey, m_prototype, v8::PropertyAttribute(v8::ReadOnly | v8::DontEnum | v8::DontDelete))))
return false;
@@ -208,6 +210,8 @@ bool CustomElementConstructorBuilder::createConstructor(Document* document, Cust
return false;
V8HiddenValue::setHiddenValue(isolate, m_prototype, V8HiddenValue::customElementIsInterfacePrototypeObject(isolate), v8::True(isolate));
+ // TODO(bashi): Use CreateDataProperty() instead of ForceSet().
+ // http://crbug.com/475206
if (!v8CallBoolean(m_prototype->ForceSet(context, v8String(isolate, "constructor"), m_constructor, v8::DontEnum)))
return false;
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptValueSerializer.cpp » ('j') | Source/bindings/templates/interface_base.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698