bindings: Use CreateDataProperty() instead of ForceSet()

Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 71 matching lines @@
         if (result.IsEmpty())
             result = toV8(event->dataAsArrayBuffer(), info.Holder(), info.GetIsolate());
         break;
     }
 
     // Overwrite the data attribute so it returns the cached result in future invocations.
     // This custom getter handler will not be called again.
     // TODO(bashi): We use ForceSet() here, and we use hidden values in other
     // places (e.g. V8CustomEventCustom.cpp). We should use the same way to
     // handle "any" attributes.
+    // TODO(bashi): Use DefineOwnProperty() instead of ForceSet().
+    // http://crbug.com/475206
     v8::PropertyAttribute dataAttr = static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly);
     if (!v8CallBoolean(info.Holder()->ForceSet(info.GetIsolate()->GetCurrentContext(), v8AtomicString(info.GetIsolate(), "data"), result, dataAttr))) {

[bashi, 2015/06/03 00:16:37]

We can't use DefineOwnProperty() here because it recursively calls this callback
and causes stack overflow.

         v8SetReturnValue(info, v8::Null(info.GetIsolate()));
         return;
     }
     v8SetReturnValue(info, result);
 }
 
 void V8MessageEvent::initMessageEventMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "initMessageEvent", "MessageEvent", info.Holder(), info.GetIsolate());
     MessageEvent* event = V8MessageEvent::toImpl(info.Holder());
@@ skipping 12 matching lines @@
     if (!isUndefinedOrNull(info[portArrayIndex])) {
         portArray = adoptPtrWillBeNoop(new MessagePortArray);
         *portArray = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort>(info[portArrayIndex], portArrayIndex + 1, info.GetIsolate(), exceptionState);
         if (exceptionState.throwIfNeeded())
             return;
     }
     event->initMessageEvent(typeArg, canBubbleArg, cancelableArg, ScriptValue(ScriptState::current(info.GetIsolate()), dataArg), originArg, lastEventIdArg, sourceArg, portArray.release());
 }
 
 } // namespace blink