Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix uninitialized error Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "V8TestInterfaceEventInit.h" 8 #include "V8TestInterfaceEventInit.h"
9 9
10 #include "bindings/core/v8/ExceptionState.h" 10 #include "bindings/core/v8/ExceptionState.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 v8::Local<v8::Object> v8Object = v8::Object::New(isolate); 54 v8::Local<v8::Object> v8Object = v8::Object::New(isolate);
55 if (!toV8EventInit(impl, v8Object, creationContext, isolate)) 55 if (!toV8EventInit(impl, v8Object, creationContext, isolate))
56 return v8::Local<v8::Value>(); 56 return v8::Local<v8::Value>();
57 if (!toV8TestInterfaceEventInit(impl, v8Object, creationContext, isolate)) 57 if (!toV8TestInterfaceEventInit(impl, v8Object, creationContext, isolate))
58 return v8::Local<v8::Value>(); 58 return v8::Local<v8::Value>();
59 return v8Object; 59 return v8Object;
60 } 60 }
61 61
62 bool toV8TestInterfaceEventInit(const TestInterfaceEventInit& impl, v8::Local<v8 ::Object> dictionary, v8::Local<v8::Object> creationContext, v8::Isolate* isolat e) 62 bool toV8TestInterfaceEventInit(const TestInterfaceEventInit& impl, v8::Local<v8 ::Object> dictionary, v8::Local<v8::Object> creationContext, v8::Isolate* isolat e)
63 { 63 {
64 // TODO(bashi): Use ForceSet() instead of Set(). http://crbug.com/476720
65 if (impl.hasStringMember()) { 64 if (impl.hasStringMember()) {
66 if (!v8CallBoolean(dictionary->Set(isolate->GetCurrentContext(), v8Strin g(isolate, "stringMember"), v8String(isolate, impl.stringMember())))) 65 if (!v8CallBoolean(dictionary->CreateDataProperty(isolate->GetCurrentCon text(), v8String(isolate, "stringMember"), v8String(isolate, impl.stringMember() ))))
67 return false; 66 return false;
68 } 67 }
69 68
70 return true; 69 return true;
71 } 70 }
72 71
73 TestInterfaceEventInit NativeValueTraits<TestInterfaceEventInit>::nativeValue(v8 ::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState) 72 TestInterfaceEventInit NativeValueTraits<TestInterfaceEventInit>::nativeValue(v8 ::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState)
74 { 73 {
75 TestInterfaceEventInit impl; 74 TestInterfaceEventInit impl;
76 V8TestInterfaceEventInit::toImpl(isolate, value, impl, exceptionState); 75 V8TestInterfaceEventInit::toImpl(isolate, value, impl, exceptionState);
77 return impl; 76 return impl;
78 } 77 }
79 78
80 } // namespace blink 79 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698