Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Side by Side Diff: Source/bindings/tests/results/modules/V8TestInterface5.cpp

Issue 1153613007: bindings: Use CreateDataProperty() instead of ForceSet() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #if ENABLE(CONDITION) 8 #if ENABLE(CONDITION)
9 #include "V8TestInterface5.h" 9 #include "V8TestInterface5.h"
10 10
(...skipping 21 matching lines...) Expand all
32 // For details, see the comment of DEFINE_WRAPPERTYPEINFO in 32 // For details, see the comment of DEFINE_WRAPPERTYPEINFO in
33 // bindings/core/v8/ScriptWrappable.h. 33 // bindings/core/v8/ScriptWrappable.h.
34 const WrapperTypeInfo& TestInterface5Implementation::s_wrapperTypeInfo = V8TestI nterface5::wrapperTypeInfo; 34 const WrapperTypeInfo& TestInterface5Implementation::s_wrapperTypeInfo = V8TestI nterface5::wrapperTypeInfo;
35 35
36 namespace TestInterface5ImplementationV8Internal { 36 namespace TestInterface5ImplementationV8Internal {
37 37
38 template<class CallbackInfo> 38 template<class CallbackInfo>
39 static void TestInterface5ImplementationForceSetAttributeOnThis(v8::Local<v8::Na me> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info) 39 static void TestInterface5ImplementationForceSetAttributeOnThis(v8::Local<v8::Na me> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info)
40 { 40 {
41 ASSERT(info.This()->IsObject()); 41 ASSERT(info.This()->IsObject());
42 // TODO(bashi): Consider using CreateDataProperty() instead of ForceSet().
42 v8::Local<v8::Object>::Cast(info.This())->ForceSet(info.GetIsolate()->GetCur rentContext(), name, v8Value); 43 v8::Local<v8::Object>::Cast(info.This())->ForceSet(info.GetIsolate()->GetCur rentContext(), name, v8Value);
43 } 44 }
44 45
45 static void TestInterface5ImplementationConstructorAttributeSetterCallback(v8::L ocal<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<voi d>& info) 46 static void TestInterface5ImplementationConstructorAttributeSetterCallback(v8::L ocal<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<voi d>& info)
46 { 47 {
47 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter"); 48 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter");
48 do { 49 do {
49 v8::Local<v8::Value> data = info.Data(); 50 v8::Local<v8::Value> data = info.Data();
50 ASSERT(data->IsExternal()); 51 ASSERT(data->IsExternal());
51 V8PerContextData* perContextData = V8PerContextData::from(info.Holder()- >CreationContext()); 52 V8PerContextData* perContextData = V8PerContextData::from(info.Holder()- >CreationContext());
(...skipping 1010 matching lines...) Expand 10 before | Expand all | Expand 10 after
1062 scriptWrappable->toImpl<TestInterface5Implementation>()->ref(); 1063 scriptWrappable->toImpl<TestInterface5Implementation>()->ref();
1063 } 1064 }
1064 1065
1065 void V8TestInterface5::derefObject(ScriptWrappable* scriptWrappable) 1066 void V8TestInterface5::derefObject(ScriptWrappable* scriptWrappable)
1066 { 1067 {
1067 scriptWrappable->toImpl<TestInterface5Implementation>()->deref(); 1068 scriptWrappable->toImpl<TestInterface5Implementation>()->deref();
1068 } 1069 }
1069 1070
1070 } // namespace blink 1071 } // namespace blink
1071 #endif // ENABLE(CONDITION) 1072 #endif // ENABLE(CONDITION)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698