bindings: Use CreateDataProperty() instead of ForceSet()

Source/bindings/templates/interface_base.cpp

 {% include 'copyright_block.txt' %}
 #include "config.h"
 {% filter conditional(conditional_string) %}
 #include "{{v8_class_or_partial}}.h"
 
 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
 #include "{{filename}}"
 {% endfor %}
 
 namespace blink {
@@ skipping 30 matching lines @@
 {# Constants #}
 {% from 'constants.cpp' import constant_getter_callback
        with context %}
 {% for constant in special_getter_constants %}
 {{constant_getter_callback(constant)}}
 {% endfor %}
 {# Attributes #}
 {% block replaceable_attribute_setter_and_callback %}
 {% if has_replaceable_attributes or has_constructor_attributes %}
 template<class CallbackInfo>
 static void {{cpp_class}}ForceSetAttributeOnThis(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info)

[jsbell, 2015/05/29 16:57:21]

Don't forget to rename this function.

[bashi, 2015/06/02 00:12:53]

Sure. Will rename it.

 {
     {% if is_check_security %}
     {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
     v8::String::Utf8Value attributeName(name);
     ExceptionState exceptionState(ExceptionState::SetterContext, *attributeName, "{{interface_name}}", info.Holder(), info.GetIsolate());
     if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), exceptionState)) {
         exceptionState.throwIfNeeded();
         return;
     }
     {% endif %}
     ASSERT(info.This()->IsObject());
+    // TODO(bashi): Consider using CreateDataProperty() instead of ForceSet().
     v8::Local<v8::Object>::Cast(info.This())->ForceSet(info.GetIsolate()->GetCurrentContext(), name, v8Value);
 }
 
 {% if has_constructor_attributes %}
 static void {{cpp_class}}ConstructorAttributeSetterCallback(v8::Local<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)
 {
     TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter");
     do {
         v8::Local<v8::Value> data = info.Data();
         ASSERT(data->IsExternal());
@@ skipping 421 matching lines @@
 {% endfor %}
 {% for attribute in attributes if attribute.is_implemented_in_private_script %}
 {{attribute_getter_implemented_in_private_script(attribute)}}
 {% if attribute.has_setter %}
 {{attribute_setter_implemented_in_private_script(attribute)}}
 {% endif %}
 {% endfor %}
 {% block partial_interface %}{% endblock %}
 } // namespace blink
 {% endfilter %}