Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: tests/RecorderTest.cpp

Issue 1153593003: Remove the SkCanvas comment API (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/CanvasTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/RecorderTest.cpp
diff --git a/tests/RecorderTest.cpp b/tests/RecorderTest.cpp
index e67de58acbd73a15964ae03cad27c4d6ddc5eb2f..829fe3e229d12c69c20957bd4e9dc081558b34d6 100644
--- a/tests/RecorderTest.cpp
+++ b/tests/RecorderTest.cpp
@@ -50,25 +50,6 @@ DEF_TEST(Recorder, r) {
REPORTER_ASSERT(r, 1 == tally.count<SkRecords::DrawRect>());
}
-// All of Skia will work fine without support for comment groups, but
-// Chrome's inspector can break. This serves as a simple regression test.
-DEF_TEST(Recorder_CommentGroups, r) {
- SkRecord record;
- SkRecorder recorder(&record, 1920, 1080);
-
- recorder.beginCommentGroup("test");
- recorder.addComment("foo", "bar");
- recorder.addComment("baz", "quux");
- recorder.endCommentGroup();
-
- Tally tally;
- tally.apply(record);
-
- REPORTER_ASSERT(r, 1 == tally.count<SkRecords::BeginCommentGroup>());
- REPORTER_ASSERT(r, 2 == tally.count<SkRecords::AddComment>());
- REPORTER_ASSERT(r, 1 == tally.count<SkRecords::EndCommentGroup>());
-}
-
// Regression test for leaking refs held by optional arguments.
DEF_TEST(Recorder_RefLeaking, r) {
// We use SaveLayer to test:
« no previous file with comments | « tests/CanvasTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698