Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1153583006: Use LookupIterator for GetElementAttributes and friends (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use LookupIterator for GetElementAttributes and friends BUG=v8:4137 LOG=n Committed: https://crrev.com/823682ea2c118f24eee774b9b0f205687c4e8b59 Cr-Commit-Position: refs/heads/master@{#28757}

Patch Set 1 #

Patch Set 2 : Adjust test expectations #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -397 lines) Patch
M src/api.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/lookup-inl.h View 1 2 3 1 chunk +16 lines, -9 lines 0 comments Download
M src/objects.h View 1 2 3 10 chunks +17 lines, -58 lines 0 comments Download
M src/objects.cc View 1 2 3 11 chunks +17 lines, -202 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 chunks +70 lines, -55 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 3 2 chunks +22 lines, -60 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 chunk +13 lines, -9 lines 0 comments Download
M test/webkit/fast/js/primitive-property-access-edge-cases-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-26 12:29:49 UTC) #1
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-26 12:30:02 UTC) #3
Igor Sheludko
lgtm
5 years, 7 months ago (2015-05-26 17:27:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153583006/60001
5 years, 6 months ago (2015-06-02 10:43:52 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-02 11:10:59 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 11:11:10 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/823682ea2c118f24eee774b9b0f205687c4e8b59
Cr-Commit-Position: refs/heads/master@{#28757}

Powered by Google App Engine
This is Rietveld 408576698