Make CPDFXFA_App / IXFA_AppProvider saner

fpdfsdk/src/javascript/global.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Context.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_EventHandler.h"
@@ skipping 101 matching lines @@
 
 global_alternate::global_alternate(CJS_Object* pJSObject)
         : CJS_EmbedObj(pJSObject),
         m_pApp(NULL)
 {
 }
 
 global_alternate::~global_alternate(void)
 {
         ASSERT(m_pApp != NULL);
-
-//      CommitGlobalPersisitentVariables();
         DestroyGlobalPersisitentVariables();
 
-        CJS_RuntimeFactory* pFactory = FPDFXFA_GetApp()->GetRuntimeFactory();
-        ASSERT(pFactory);
-
+        CJS_RuntimeFactory* pFactory = CPDFXFA_App::GetInstance()->GetRuntimeFactory();
         pFactory->ReleaseGlobalData();
 }
-  
+
 void global_alternate::Initial(CPDFDoc_Environment* pApp)
 {
         m_pApp = pApp;
 
-        CJS_RuntimeFactory* pFactory = FPDFXFA_GetApp()->GetRuntimeFactory();
-        ASSERT(pFactory);
+        CJS_RuntimeFactory* pFactory = CPDFXFA_App::GetInstance()->GetRuntimeFactory();
         m_pGlobalData = pFactory->NewGlobalData(pApp);
         UpdateGlobalPersistentVariables();
 }
 
 FX_BOOL global_alternate::QueryProperty(FX_LPCWSTR propname)
 {
         return CFX_WideString(propname) != L"setPersistent";
 }
 
 FX_BOOL global_alternate::DelProperty(IFXJS_Context* cc, FX_LPCWSTR propname, CFX_WideString& sError)
@@ skipping 476 matching lines @@
   if (nHash == JSCONST_nDateHash)
     return VT_date;
   if (nHash == JSCONST_nObjectHash)
     return VT_object;
   if (nHash == JSCONST_nFXobjHash)
     return VT_fxobject;
 
   return VT_unknown;
 }