net/base/network_quality_estimator.h - Issue 1153543016: Trigger LoFi based on NQE and use hysteresis to prevent frequent changes in network quality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/network_quality_estimator.h

Issue 1153543016: Trigger LoFi based on NQE and use hysteresis to prevent frequent changes in network quality (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change in connection type triggers change in network quality despite hysteresis. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/network_quality_estimator.h

diff --git a/net/base/network_quality_estimator.h b/net/base/network_quality_estimator.h

index ecfa08af6b8341b3a9bb06897a89baa42651c7b7..8be76c34f2bd4646bc13c4a096111dd179a16e69 100644

--- a/net/base/network_quality_estimator.h

+++ b/net/base/network_quality_estimator.h

@@ -34,7 +34,8 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator

~NetworkQualityEstimator() override;

// Returns an estimate of the current network quality.

- NetworkQuality GetEstimate() const;

+ // Virtualized for testing.

+ virtual NetworkQuality GetEstimate() const;

// Notifies NetworkQualityEstimator that a response has been received.

// |prefilter_bytes_read| is the count of the bytes received prior to

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc ('k') | no next file » | no next file with comments »