components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h - Issue 1153543016: Trigger LoFi based on NQE and use hysteresis to prevent frequent changes in network quality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h

Issue 1153543016: Trigger LoFi based on NQE and use hysteresis to prevent frequent changes in network quality (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change in connection type triggers change in network quality despite hysteresis. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h

index d31ed9a964a7184e7ea1a5c9ace46f7ce8812d94..efb90708452e2e72c0b4448927d53573dfc3cec6 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h

@@ -80,8 +80,7 @@ class TestDataReductionProxyConfig : public DataReductionProxyConfig {

void SetNetworkProhibitivelySlow(bool network_quality_prohibitively_slow);

bool IsNetworkQualityProhibitivelySlow(

- const net::NetworkQualityEstimator* network_quality_estimator)

- const override;

+ const net::NetworkQualityEstimator* network_quality_estimator) override;

net::NetworkInterfaceList* interfaces() {

return network_interfaces_.get();

@@ -133,7 +132,7 @@ class MockDataReductionProxyConfig : public TestDataReductionProxyConfig {

MOCK_METHOD2(SecureProxyCheck,

void(const GURL& secure_proxy_check_url,

FetcherResponseCallback fetcher_callback));

- MOCK_CONST_METHOD1(

+ MOCK_METHOD1(

IsNetworkQualityProhibitivelySlow,

bool(const net::NetworkQualityEstimator* network_quality_estimator));

MOCK_CONST_METHOD0(IsIncludedInLoFiEnabledFieldTrial, bool());