Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1153543015: media: Remove kDisableInfobarForProtectedMediaIdentifier flag. (Closed)

Created:
5 years, 6 months ago by xhwang
Modified:
5 years, 6 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Remove kDisableInfobarForProtectedMediaIdentifier flag. This flag is currently not used anywhere. BUG=489429 R=ddorwin@chromium.org Committed: https://crrev.com/79707766af32179af967bdcba7520961e1ff00d7 Cr-Commit-Position: refs/heads/master@{#334208}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Patch Set 3 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -41 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context.cc View 1 2 3 chunks +1 line, -15 lines 0 comments Download
M media/base/media_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/base/media_switches.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
xhwang
5 years, 6 months ago (2015-06-05 21:16:56 UTC) #1
xhwang
ddorwin: This is a trivial CL; kindly ping...
5 years, 6 months ago (2015-06-08 16:34:32 UTC) #2
ddorwin
LG, but I think you need to modify a .grd file. https://codereview.chromium.org/1153543015/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): ...
5 years, 6 months ago (2015-06-11 02:28:53 UTC) #3
xhwang
comments addressed
5 years, 6 months ago (2015-06-11 04:45:50 UTC) #4
xhwang
https://codereview.chromium.org/1153543015/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/1153543015/diff/1/chrome/browser/about_flags.cc#oldcode842 chrome/browser/about_flags.cc:842: IDS_FLAGS_DISABLE_INFOBAR_FOR_PROTECTED_MEDIA_IDENTIFIER_NAME, On 2015/06/11 02:28:53, ddorwin wrote: > You probably ...
5 years, 6 months ago (2015-06-11 04:46:47 UTC) #5
ddorwin
lgtm
5 years, 6 months ago (2015-06-11 16:21:13 UTC) #6
xhwang
rebase only
5 years, 6 months ago (2015-06-12 16:36:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153543015/40001
5 years, 6 months ago (2015-06-12 17:48:26 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-12 18:47:33 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 18:48:39 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/79707766af32179af967bdcba7520961e1ff00d7
Cr-Commit-Position: refs/heads/master@{#334208}

Powered by Google App Engine
This is Rietveld 408576698