Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1153543012: Sync the File API interfaces with the spec (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
jsbell
CC:
blink-reviews, arv+blink, tzik, vivekg_samsung, nhiroki, vivekg, Inactive, kinuko+fileapi
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the File API interfaces with the spec https://w3c.github.io/FileAPI/ The only changes to the generated code are due to the encoding->label rename and [Measure], and neither is observable. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196577

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -20 lines) Patch
M Source/core/fileapi/Blob.idl View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/fileapi/BlobPropertyBag.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/fileapi/File.idl View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/fileapi/FileError.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fileapi/FileList.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/fileapi/FilePropertyBag.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/fileapi/FileReader.idl View 2 chunks +17 lines, -10 lines 0 comments Download
M Source/core/fileapi/FileReaderSync.idl View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
philipj_slow
PTAL
5 years, 6 months ago (2015-06-04 22:45:43 UTC) #2
jsbell
lgtm
5 years, 6 months ago (2015-06-04 23:50:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153543012/20001
5 years, 6 months ago (2015-06-05 13:47:15 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 14:48:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196577

Powered by Google App Engine
This is Rietveld 408576698