Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 115353005: Introduces a CHECK to analyze the crash reason. (Closed)

Created:
7 years ago by Jun Mukai
Modified:
7 years ago
Reviewers:
dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Introduces a CHECK to analyze the crash reason. BUG=322320 R=dewittj@chromium.org TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241118

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/notifications/desktop_notification_service.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Jun Mukai
7 years ago (2013-12-13 20:53:42 UTC) #1
dewittj
lgtm lgtm
7 years ago (2013-12-14 01:24:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/115353005/10001
7 years ago (2013-12-14 01:28:06 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) app_list_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chromedriver2_unittests, ...
7 years ago (2013-12-14 02:41:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/115353005/10001
7 years ago (2013-12-14 08:08:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204123
7 years ago (2013-12-14 09:40:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/115353005/10001
7 years ago (2013-12-14 19:20:53 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204234
7 years ago (2013-12-14 20:25:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/115353005/10001
7 years ago (2013-12-15 18:51:28 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204403
7 years ago (2013-12-15 19:51:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/115353005/10001
7 years ago (2013-12-16 18:03:33 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204983
7 years ago (2013-12-16 20:02:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/115353005/10001
7 years ago (2013-12-16 23:05:14 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=205408
7 years ago (2013-12-17 01:54:28 UTC) #14
Jun Mukai
On 2013/12/17 01:54:28, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years ago (2013-12-17 02:40:09 UTC) #15
Jun Mukai
7 years ago (2013-12-17 02:41:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 manually as r241118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698