content/browser/fileapi/file_system_dir_url_request_job_unittest.cc - Issue 1153503009: Revert "content: Remove use of MessageLoopProxy and deprecated MessageLoop APIs"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/fileapi/file_system_dir_url_request_job_unittest.cc

Issue 1153503009: Revert "content: Remove use of MessageLoopProxy and deprecated MessageLoop APIs" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/file_system_context_unittest.cc ('k') | content/browser/fileapi/file_system_operation_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/fileapi/file_system_dir_url_request_job_unittest.cc

diff --git a/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc b/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc

index 43dd81295c16e25a006227398b6af09c5a7371e4..ff913ecaa18270c5fa6b8c01c73b9f7dc7e07d6e 100644

--- a/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc

+++ b/content/browser/fileapi/file_system_dir_url_request_job_unittest.cc

@@ -10,13 +10,12 @@

#include "base/files/file_util.h"

#include "base/files/scoped_temp_dir.h"

#include "base/format_macros.h"

-#include "base/location.h"

#include "base/memory/scoped_vector.h"

#include "base/memory/weak_ptr.h"

+#include "base/message_loop/message_loop.h"

#include "base/run_loop.h"

#include "base/strings/string_piece.h"

#include "base/strings/utf_string_conversions.h"

-#include "base/thread_task_runner_handle.h"

#include "content/public/test/mock_special_storage_policy.h"

#include "content/public/test/test_file_system_backend.h"

#include "content/public/test/test_file_system_context.h"

@@ -154,7 +153,7 @@ class FileSystemDirURLRequestJobTest : public testing::Test {

ScopedVector<storage::FileSystemBackend> additional_providers;

additional_providers.push_back(new TestFileSystemBackend(

- base::ThreadTaskRunnerHandle::Get().get(), *mnt_point));

+ base::MessageLoopProxy::current().get(), *mnt_point));

std::vector<storage::URLRequestAutoMountHandler> handlers;

handlers.push_back(base::Bind(&TestAutoMountForURLRequest));

@@ -286,7 +285,7 @@ class FileSystemDirURLRequestJobTest : public testing::Test {

}

// Put the message loop at the top, so that it's the last thing deleted.

- // Delete all task runner objects before the MessageLoop, to help prevent

+ // Delete all MessageLoopProxy objects before the MessageLoop, to help prevent

// leaks caused by tasks posted during shutdown.

base::MessageLoopForIO message_loop_;