Run python update_extension_permission.py

Run python update_extension_permission.py

extensions\common\permissions\api_permission.h had a value added (on
May 11 for bug 485227) that threw off the numbering. Move it to the
bottom. We should probably also merge this to the branch.

BUG=485227
NOPRESUBMIT=true

Committed: https://crrev.com/26d973e101a593728ab6b9f0af2aa757311bfbf8
Cr-Commit-Position: refs/heads/master@{#332286}

[ncarter (slow), 2015-05-26 22:20:43]

nick@chromium.org changed reviewers:
+ isherman@chromium.org, kalman@chromium.org

[ncarter (slow), 2015-05-26 22:20:44]

kalman@chromium.org: Please review changes in extensions

isherman@chromium.org: Please review changes in tools\metrics

[not at google - send to devlin, 2015-05-26 22:24:34]

lgtm, I guess this only messed up very recently and bad data hasn't gotten in?

[Ilya Sherman, 2015-05-26 22:43:05]

LGTM.  However, if we can't merge this to the branch, then we should probably
rename the histogram, yet again.  It would also be nice to either have a
PRESUBMIT check; or at least use the same OWNERS approval policy as we do for
extensions/browser/extension_function_histogram_value.h, so that this sort of
error is hard to make in the future.

[Ilya Sherman, 2015-05-26 22:46:50]

Also, boy, it is pretty unclear why we have both ExtensionPermission2 and
ExtensionPermission3, with neither of them deprecated.  Perhaps there are
clearer names that we could use?  (Sorry, I realize this is orthogonal to your
CL, but it's something I noticed that seems pretty relevant.)

[ncarter (slow), 2015-05-26 23:32:37]

On 2015/05/26 22:46:50, Ilya Sherman wrote:
> Also, boy, it is pretty unclear why we have both ExtensionPermission2 and
> ExtensionPermission3, with neither of them deprecated.  Perhaps there are
> clearer names that we could use?  (Sorry, I realize this is orthogonal to your
> CL, but it's something I noticed that seems pretty relevant.)

Honestly, I just stumbled into this whole mess by running the script. I'm
happy to help with any cleanup that's needed, but will need some help
figuring out what the existing state of the world is.

I was going to tackle the presubmits next, but haven't even looked at
what's there, or what went wrong with the CL that introduced this problem.

[ncarter (slow), 2015-05-26 23:33:50]

On 2015/05/26 22:24:34, kalman wrote:
> lgtm, I guess this only messed up very recently and bad data hasn't gotten in?

Yes, my hope is that it's just been a couple weeks and we caught it fast enough
that we can shrug off the bad data. Having said that, I'm not a consumer of this
data, so I don't really know. Do you?

[ncarter (slow), 2015-05-26 23:34:42]

nick@chromium.org changed reviewers:
+ khorimoto@chromium.org

[ncarter (slow), 2015-05-26 23:34:42]

+kkhorimoto, FYI

[ncarter (slow), 2015-05-26 23:34:55]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2015-05-26 23:36:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1153503003/1

[commit-bot: I haz the power, 2015-05-26 23:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-26 23:45:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ncarter (slow), 2015-06-01 21:44:58]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2015-06-01 22:40:02]

The CQ bit was unchecked by nick@chromium.org

[ncarter (slow), 2015-06-01 22:49:12]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2015-06-01 22:49:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1153503003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2015-06-01 23:34:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1153503003/20001

[commit-bot: I haz the power, 2015-06-02 01:02:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-02 01:03:35]

Patchset 2 (id:??) landed as
https://crrev.com/26d973e101a593728ab6b9f0af2aa757311bfbf8
Cr-Commit-Position: refs/heads/master@{#332286}

[Kyle Horimoto, 2015-06-02 01:18:30]

Thanks for fixing my mistake! :)

[Marc Treib, 2015-06-03 09:46:11]

On 2015/06/02 01:18:30, Kyle Horimoto wrote:
> Thanks for fixing my mistake! :)

Post-submit drive-by :)

We do (now) have a presubmit to catch this case - the script was fixed in
https://codereview.chromium.org/1129153003/, apparently just one day after the
bad edit came in.

The ExtensionPermission2 histograms will be removed Very Soon.