Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc

Issue 11535008: Implement mediaGalleriesPrivate api to notify extensions about gallery changed events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc
diff --git a/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc b/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc
index 7b83d03e1965dfab2ae8b9a50270de5671c84f2b..83bfe6f9e1cc709821c9aed6320bebb1cc787514 100644
--- a/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc
+++ b/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.cc
@@ -4,21 +4,116 @@
#include "chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api.h"
-#include "chrome/browser/extensions/api/media_galleries_private/media_galleries_private_api_factory.h"
+#include "base/basictypes.h"
+#include "base/bind.h"
+#include "base/file_path.h"
+#include "base/location.h"
+#include "base/string_number_conversions.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/extensions/api/media_galleries_private/gallery_watch_manager.h"
#include "chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.h"
+#include "chrome/browser/extensions/api/media_galleries_private/media_gallery_extension_notification_observer.h"
#include "chrome/browser/extensions/event_names.h"
#include "chrome/browser/extensions/event_router.h"
+#include "chrome/browser/extensions/extension_function.h"
#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/media_gallery/media_file_system_registry.h"
+#include "chrome/browser/media_gallery/media_galleries_preferences.h"
+#include "chrome/browser/system_monitor/media_storage_util.h"
+#include "chrome/common/extensions/api/media_galleries_private.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/render_view_host.h"
namespace extensions {
+namespace AddGalleryWatch =
+ extensions::api::media_galleries_private::AddGalleryWatch;
+namespace RemoveGalleryWatch =
+ extensions::api::media_galleries_private::RemoveGalleryWatch;
+
+namespace {
+
+const char kInvalidGalleryIDError[] = "Specified invalid gallery identifier";
Lei Zhang 2012/12/19 22:35:50 Just say "Invalid gallery ID"
kmadhusu 2012/12/19 23:13:17 Done.
+
+// Returns the absolute file path of the gallery specified by the |gallery_id|.
+// Returns an empty file path if the |gallery_id| is invalid.
+FilePath GetGalleryAbsolutePath(chrome::MediaGalleryPrefId gallery_id,
+ Profile* profile,
+ const Extension* extension) {
+ DCHECK(profile);
+ DCHECK(extension);
+ chrome::MediaFileSystemRegistry* registry =
+ g_browser_process->media_file_system_registry();
+ DCHECK(registry);
+ chrome::MediaGalleriesPreferences* preferences =
+ registry->GetPreferences(profile);
+ if (!preferences)
+ return FilePath();
+
+ const chrome::MediaGalleryPrefIdSet permitted_galleries =
+ preferences->GalleriesForExtension(*extension);
+ if (permitted_galleries.empty() ||
+ permitted_galleries.find(gallery_id) == permitted_galleries.end())
+ return FilePath();
+
+ const chrome::MediaGalleriesPrefInfoMap& galleries_info =
+ preferences->known_galleries();
+ return chrome::MediaStorageUtil::FindDevicePathById(
+ galleries_info.find(gallery_id)->second.device_id);
+}
+
+// Handles the profile shutdown event on the file thread to clean up
+// GalleryWatchManager.
+void HandleProfileShutdownOnFileThread(Profile* profile) {
+ DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+ GalleryWatchManager::OnProfileShutdown(profile);
+}
+
+// Sets up a gallery watch on the file thread for the extension specified by the
+// |extension_id|.
+// |profile| specifies the extension profile.
+// |gallery_id| specifies the gallery identifier.
+// |gallery_file_path| specifies the absolute gallery path.
+// Returns true, if the watch setup operation was successful.
+bool SetupGalleryWatchOnFileThread(Profile* profile,
+ chrome::MediaGalleryPrefId gallery_id,
+ const FilePath& gallery_file_path,
+ const std::string& extension_id) {
+ DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+ return GalleryWatchManager::GetForProfile(profile)->StartGalleryWatch(
+ gallery_id, gallery_file_path, extension_id);
+}
+
+// Cancels the gallery watch for the extension specified by the |extension_id|
+// on the file thread.
+void RemoveGalleryWatchOnFileThread(Profile* profile,
+ const FilePath& gallery_file_path,
+ const std::string& extension_id) {
+ DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
+ if (!GalleryWatchManager::HasForProfile(profile))
+ return;
+ GalleryWatchManager::GetForProfile(profile)->StopGalleryWatch(
+ gallery_file_path, extension_id);
+}
+
+} // namespace
+
+
+///////////////////////////////////////////////////////////////////////////////
+// MediaGalleriesPrivateAPI //
+///////////////////////////////////////////////////////////////////////////////
+
MediaGalleriesPrivateAPI::MediaGalleriesPrivateAPI(Profile* profile)
: profile_(profile) {
+ DCHECK(profile_);
+ extension_notification_observer_.reset(
+ new MediaGalleryExtensionNotificationObserver(profile_));
ExtensionSystem::Get(profile_)->event_router()->RegisterObserver(
this, event_names::kOnAttachEventName);
- ExtensionSystem::Get(profile_)->event_router()->RegisterObserver(
+ ExtensionSystem::Get(profile_)->event_router()->RegisterObserver(
this, event_names::kOnDetachEventName);
-
+ ExtensionSystem::Get(profile_)->event_router()->RegisterObserver(
+ this, event_names::kOnGalleryChangedEventName);
}
MediaGalleriesPrivateAPI::~MediaGalleriesPrivateAPI() {
@@ -26,13 +121,125 @@ MediaGalleriesPrivateAPI::~MediaGalleriesPrivateAPI() {
void MediaGalleriesPrivateAPI::Shutdown() {
ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this);
+ content::BrowserThread::PostTask(
+ content::BrowserThread::FILE, FROM_HERE,
+ base::Bind(&HandleProfileShutdownOnFileThread, profile_));
}
void MediaGalleriesPrivateAPI::OnListenerAdded(
- const extensions::EventListenerInfo& details) {
+ const EventListenerInfo& details) {
media_galleries_private_event_router_.reset(
new MediaGalleriesPrivateEventRouter(profile_));
- ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this);
+}
+
+///////////////////////////////////////////////////////////////////////////////
+// MediaGalleriesPrivateAddGalleryWatchFunction //
+///////////////////////////////////////////////////////////////////////////////
+MediaGalleriesPrivateAddGalleryWatchFunction::
+~MediaGalleriesPrivateAddGalleryWatchFunction() {
+}
+
+bool MediaGalleriesPrivateAddGalleryWatchFunction::RunImpl() {
+ DCHECK(profile_);
+ DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ if (!render_view_host() || !render_view_host()->GetProcess())
+ return false;
+
+ scoped_ptr<AddGalleryWatch::Params> params(
+ AddGalleryWatch::Params::Create(*args_));
+ EXTENSION_FUNCTION_VALIDATE(params.get());
+
+ if (params->gallery_id < 0) {
+ error_ = kInvalidGalleryIDError;
+ return false;
+ }
+
+ // First param is the gallery identifier to watch.
+ chrome::MediaGalleryPrefId gallery_pref_id =
+ static_cast<uint64>(params->gallery_id);
+ FilePath gallery_file_path(
+ GetGalleryAbsolutePath(gallery_pref_id, profile_, GetExtension()));
+ if (gallery_file_path.empty()) {
+ error_ = kInvalidGalleryIDError;
+ return false;
+ }
+
+#if defined(OS_WIN)
+ content::BrowserThread::PostTaskAndReplyWithResult(
+ content::BrowserThread::FILE,
+ FROM_HERE,
+ base::Bind(&SetupGalleryWatchOnFileThread,
+ profile_,
+ gallery_pref_id,
+ gallery_file_path,
+ extension_id()),
+ base::Bind(&MediaGalleriesPrivateAddGalleryWatchFunction::HandleResponse,
+ this,
+ gallery_pref_id));
+#else
+ // Recursive gallery watch operation is not currently supported on
+ // non-windows platforms. Please refer to crbug.com/144491 for more details.
+ HandleResponse(gallery_pref_id, false);
+#endif
+ return true;
+}
+
+void MediaGalleriesPrivateAddGalleryWatchFunction::HandleResponse(
+ chrome::MediaGalleryPrefId gallery_id,
+ bool success) {
+ DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ extensions::api::media_galleries_private::AddGalleryWatchResult result;
+ result.gallery_id = gallery_id;
+ result.success = success;
+ SetResult(result.ToValue().release());
+ SendResponse(true);
+}
+
+
+///////////////////////////////////////////////////////////////////////////////
+// MediaGalleriesPrivateRemoveGalleryWatchFunction //
+///////////////////////////////////////////////////////////////////////////////
+
+MediaGalleriesPrivateRemoveGalleryWatchFunction::
+~MediaGalleriesPrivateRemoveGalleryWatchFunction() {
+}
+
+bool MediaGalleriesPrivateRemoveGalleryWatchFunction::RunImpl() {
+ DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+#if defined(OS_WIN)
+ if (!render_view_host() || !render_view_host()->GetProcess())
+ return false;
+
+ // Remove gallery watch operation is currently supported on windows platforms.
+ // Please refer to crbug.com/144491 for more details.
+ scoped_ptr<RemoveGalleryWatch::Params> params(
+ RemoveGalleryWatch::Params::Create(*args_));
+ EXTENSION_FUNCTION_VALIDATE(params.get());
+
+ if (params->gallery_id < 0) {
+ error_ = kInvalidGalleryIDError;
+ return false;
+ }
+
+ // First param is the gallery identifier.
+ chrome::MediaGalleryPrefId gallery_pref_id =
+ static_cast<uint64>(params->gallery_id);
+
+ FilePath gallery_file_path(
+ GetGalleryAbsolutePath(gallery_pref_id, profile_, GetExtension()));
+ if (gallery_file_path.empty()) {
+ error_ = kInvalidGalleryIDError;
+ return false;
+ }
+
+ content::BrowserThread::PostTask(
+ content::BrowserThread::FILE, FROM_HERE,
+ base::Bind(&RemoveGalleryWatchOnFileThread,
+ profile_,
+ gallery_file_path,
+ extension_id()));
+#endif
+ return true;
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698