Chromium Code Reviews

Issue 1153493002: Remove CSSKeyframesRule.insertRule() (Closed)

Created:
5 years, 7 months ago by philipj_slow
Modified:
5 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, shans, rjwright, vivekg_samsung, blink-reviews-animation_chromium.org, blink-reviews-css, vivekg, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, arv+blink, rwlbuis, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Stats (+15 lines, -32 lines)
M LayoutTests/animations/change-keyframes.html View 1 chunk +4 lines, -4 lines 0 comments
M LayoutTests/animations/change-keyframes-expected.txt View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/keyframes-cssom-prefixed-02.html View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/animations/keyframes-cssom-prefixed-02-expected.txt View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/keyframes-cssom-unprefixed-02.html View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/animations/keyframes-cssom-unprefixed-02-expected.txt View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/keyframes-missing-arguments.html View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/animations/keyframes-missing-arguments-expected.txt View 1 chunk +0 lines, -2 lines 0 comments
M LayoutTests/animations/keyframes-rule.html View 2 chunks +7 lines, -7 lines 0 comments
M LayoutTests/animations/keyframes-rule-expected.txt View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/http/tests/css/resources/shared-stylesheet-mutation.js View 1 chunk +1 line, -1 line 0 comments
M LayoutTests/http/tests/css/shared-stylesheet-mutation-expected.txt View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments
M Source/core/css/CSSKeyframesRule.idl View 1 chunk +1 line, -2 lines 0 comments
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments

Messages

Total messages: 7 (2 generated)
philipj_slow
tests
5 years, 7 months ago (2015-05-21 21:58:15 UTC) #1
philipj_slow
PTAL. I have this CL ready, so if you LGTM the blink-dev intent it's ready ...
5 years, 7 months ago (2015-05-22 15:53:01 UTC) #3
pdr.
On 2015/05/22 at 15:53:01, philipj wrote: > PTAL. I have this CL ready, so if ...
5 years, 7 months ago (2015-05-22 16:35:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153493002/20001
5 years, 7 months ago (2015-05-22 16:51:01 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 17:04:23 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195797

Powered by Google App Engine