Chromium Code Reviews

Unified Diff: test/cctest/compiler/test-js-typed-lowering.cc

Issue 1153483002: [turbofan] Enable deoptimization for non-asm.js TurboFan code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Don't use the HasDeoptimizationData() predicate, it's wrong. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: test/cctest/compiler/test-js-typed-lowering.cc
diff --git a/test/cctest/compiler/test-js-typed-lowering.cc b/test/cctest/compiler/test-js-typed-lowering.cc
index e9cc5156eca83b27760d684025eb7924a52b5c4d..0de47332ea089f5c7dc9b7bc774073a33b10fb57 100644
--- a/test/cctest/compiler/test-js-typed-lowering.cc
+++ b/test/cctest/compiler/test-js-typed-lowering.cc
@@ -712,8 +712,6 @@ TEST_WITH_STRONG(MixedComparison1) {
TEST_WITH_STRONG(RemoveToNumberEffects) {
- FLAG_turbo_deoptimization = true;
-
JSTypedLoweringTester R;
Node* effect_use = NULL;
@@ -725,27 +723,16 @@ TEST_WITH_STRONG(RemoveToNumberEffects) {
switch (i) {
case 0:
- if (FLAG_turbo_deoptimization) {
- DCHECK(OperatorProperties::GetFrameStateInputCount(
- R.javascript.ToNumber()) == 1);
- effect_use = R.graph.NewNode(R.javascript.ToNumber(), p0, R.context(),
- frame_state, ton, R.start());
- } else {
+ DCHECK(OperatorProperties::GetFrameStateInputCount(
+ R.javascript.ToNumber()) == 1);
effect_use = R.graph.NewNode(R.javascript.ToNumber(), p0, R.context(),
- ton, R.start());
- }
+ frame_state, ton, R.start());
break;
case 1:
- if (FLAG_turbo_deoptimization) {
- DCHECK(OperatorProperties::GetFrameStateInputCount(
- R.javascript.ToNumber()) == 1);
- effect_use =
- R.graph.NewNode(R.javascript.ToNumber(), ton, R.context(),
- frame_state, ton, R.start());
- } else {
- effect_use = R.graph.NewNode(R.javascript.ToNumber(), ton,
- R.context(), ton, R.start());
- }
+ DCHECK(OperatorProperties::GetFrameStateInputCount(
+ R.javascript.ToNumber()) == 1);
+ effect_use = R.graph.NewNode(R.javascript.ToNumber(), ton, R.context(),
+ frame_state, ton, R.start());
break;
case 2:
effect_use = R.graph.NewNode(R.common.EffectPhi(1), ton, R.start());

Powered by Google App Engine