Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1153473009: Fix for DCHECK failure at startup of gin_shell. (Closed)

Created:
5 years, 6 months ago by Krzysztof Olczyk
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for DCHECK failure at startup of gin_shell. It was introduced by rewriting code to use SingeThreadTaskRunner instead of MessageLoopProxy. Reproduces with gin_unittests too. BUG= Committed: https://crrev.com/65e946531a3de45739107ea1e2a58a314d245f9b Cr-Commit-Position: refs/heads/master@{#332597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M gin/shell/gin_main.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Krzysztof Olczyk
Hi jochen, could you review this small fix for failing DCHECKs in gin_shell and gin_unittests?
5 years, 6 months ago (2015-06-03 10:01:15 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-03 11:18:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153473009/1
5 years, 6 months ago (2015-06-03 11:23:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 11:50:01 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 11:51:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65e946531a3de45739107ea1e2a58a314d245f9b
Cr-Commit-Position: refs/heads/master@{#332597}

Powered by Google App Engine
This is Rietveld 408576698