Pepper: Remove unused interface versions.

Pepper: Remove unused interface versions.

Versions 0.2 of PPB_AudioInput_Dev and PPB_VideoCapture_Dev are no longer used.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243205

[yzshen1, 2014-01-06 17:23:19]

Thanks Justin! I am very happy to see this change.

Out of curious, are you planning to remove the resource array API/impl in a
separate CL?

https://codereview.chromium.org/115343006/diff/100001/ppapi/api/dev/ppb_audio...
File ppapi/api/dev/ppb_audio_input_dev.idl (right):

https://codereview.chromium.org/115343006/diff/100001/ppapi/api/dev/ppb_audio...
ppapi/api/dev/ppb_audio_input_dev.idl:12: M25 = 0.3,
I don't remember, is v0.2 the reason why we cannot auto-gen the thunk from IDL?
(If yes, please consider auto-gen it.)

https://codereview.chromium.org/115343006/diff/100001/ppapi/api/dev/ppb_video...
File ppapi/api/dev/ppb_video_capture_dev.idl (right):

https://codereview.chromium.org/115343006/diff/100001/ppapi/api/dev/ppb_video...
ppapi/api/dev/ppb_video_capture_dev.idl:10: M25 = 0.3
Can we auto gen the thunk?

https://codereview.chromium.org/115343006/diff/100001/ppapi/shared_impl/ppb_d...
File ppapi/shared_impl/ppb_device_ref_shared.cc (right):

https://codereview.chromium.org/115343006/diff/100001/ppapi/shared_impl/ppb_d...
ppapi/shared_impl/ppb_device_ref_shared.cc:7: #include
"base/memory/scoped_ptr.h"
this is not needed (and also line 10)

https://codereview.chromium.org/115343006/diff/100001/ppapi/shared_impl/ppb_d...
File ppapi/shared_impl/ppb_device_ref_shared.h (right):

https://codereview.chromium.org/115343006/diff/100001/ppapi/shared_impl/ppb_d...
ppapi/shared_impl/ppb_device_ref_shared.h:9: #include <vector>
nit: vector is not needed anymore.

[teravest, 2014-01-06 17:32:57]

On Mon, Jan 6, 2014 at 10:23 AM,  <yzshen@chromium.org> wrote:
> Thanks Justin! I am very happy to see this change.
>
> Out of curious, are you planning to remove the resource array API/impl in a
> separate CL?

Yes.

>
>
>
https://codereview.chromium.org/115343006/diff/100001/ppapi/api/dev/ppb_audio...
> File ppapi/api/dev/ppb_audio_input_dev.idl (right):
>
>
https://codereview.chromium.org/115343006/diff/100001/ppapi/api/dev/ppb_audio...
> ppapi/api/dev/ppb_audio_input_dev.idl:12: M25 = 0.3,
> I don't remember, is v0.2 the reason why we cannot auto-gen the thunk
> from IDL?
> (If yes, please consider auto-gen it.)

Autogenerating the thunk doesn't work properly, it looks like
generate_thunk gets confused about the callback types and emits the
wrong code for this interface. That should be fixed, but I can't
automatically generate them now.

>
>
https://codereview.chromium.org/115343006/diff/100001/ppapi/api/dev/ppb_video...
> File ppapi/api/dev/ppb_video_capture_dev.idl (right):
>
>
https://codereview.chromium.org/115343006/diff/100001/ppapi/api/dev/ppb_video...
> ppapi/api/dev/ppb_video_capture_dev.idl:10: M25 = 0.3
> Can we auto gen the thunk?

Nope, there's some tricky stuff happening in the thunk.

>
>
https://codereview.chromium.org/115343006/diff/100001/ppapi/shared_impl/ppb_d...
> File ppapi/shared_impl/ppb_device_ref_shared.cc (right):
>
>
https://codereview.chromium.org/115343006/diff/100001/ppapi/shared_impl/ppb_d...
> ppapi/shared_impl/ppb_device_ref_shared.cc:7: #include
> "base/memory/scoped_ptr.h"
> this is not needed (and also line 10)

Removed.

>
>
https://codereview.chromium.org/115343006/diff/100001/ppapi/shared_impl/ppb_d...
> File ppapi/shared_impl/ppb_device_ref_shared.h (right):
>
>
https://codereview.chromium.org/115343006/diff/100001/ppapi/shared_impl/ppb_d...
> ppapi/shared_impl/ppb_device_ref_shared.h:9: #include <vector>
> nit: vector is not needed anymore.

Removed.

>
> https://codereview.chromium.org/115343006/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[yzshen1, 2014-01-06 17:42:57]

LGTM

Thanks!

[commit-bot: I haz the power, 2014-01-06 18:05:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/teravest@chromium.org/115343006/240001

[commit-bot: I haz the power, 2014-01-06 23:51:43]

Change committed as 243205