Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: Source/core/animation/EffectInputTest.cpp

Issue 1153413007: Resolve style in element.animate() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make unittests work again Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/EffectInputTest.cpp
diff --git a/Source/core/animation/EffectInputTest.cpp b/Source/core/animation/EffectInputTest.cpp
index 21ab7bcb4d8a0b11ee51a7e6e6a1a5b491d2413c..9a9eb10fa287c25371a33b088d334d518223eee1 100644
--- a/Source/core/animation/EffectInputTest.cpp
+++ b/Source/core/animation/EffectInputTest.cpp
@@ -52,7 +52,7 @@ TEST_F(AnimationEffectInputTest, SortedOffsets)
jsKeyframes.append(Dictionary(keyframe1, m_isolate, exceptionState));
jsKeyframes.append(Dictionary(keyframe2, m_isolate, exceptionState));
- RefPtrWillBeRawPtr<EffectModel> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState);
+ RefPtrWillBeRawPtr<EffectModel> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);
EXPECT_FALSE(exceptionState.hadException());
const KeyframeEffectModelBase& keyframeEffect = *toKeyframeEffectModelBase(animationEffect.get());
EXPECT_EQ(1.0, keyframeEffect.getFrames()[1]->offset());
@@ -72,7 +72,7 @@ TEST_F(AnimationEffectInputTest, UnsortedOffsets)
jsKeyframes.append(Dictionary(keyframe1, m_isolate, exceptionState));
jsKeyframes.append(Dictionary(keyframe2, m_isolate, exceptionState));
- EffectInput::convert(element.get(), jsKeyframes, exceptionState);
+ EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);
EXPECT_TRUE(exceptionState.hadException());
EXPECT_EQ(InvalidModificationError, exceptionState.code());
}
@@ -94,7 +94,7 @@ TEST_F(AnimationEffectInputTest, LooslySorted)
jsKeyframes.append(Dictionary(keyframe2, m_isolate, exceptionState));
jsKeyframes.append(Dictionary(keyframe3, m_isolate, exceptionState));
- RefPtrWillBeRawPtr<EffectModel> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState);
+ RefPtrWillBeRawPtr<EffectModel> animationEffect = EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);
EXPECT_FALSE(exceptionState.hadException());
const KeyframeEffectModelBase& keyframeEffect = *toKeyframeEffectModelBase(animationEffect.get());
EXPECT_EQ(1, keyframeEffect.getFrames()[2]->offset());
@@ -121,7 +121,7 @@ TEST_F(AnimationEffectInputTest, OutOfOrderWithNullOffsets)
jsKeyframes.append(Dictionary(keyframe3, m_isolate, exceptionState));
jsKeyframes.append(Dictionary(keyframe4, m_isolate, exceptionState));
- EffectInput::convert(element.get(), jsKeyframes, exceptionState);
+ EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);
EXPECT_TRUE(exceptionState.hadException());
}
@@ -143,7 +143,7 @@ TEST_F(AnimationEffectInputTest, Invalid)
jsKeyframes.append(Dictionary(keyframe2, m_isolate, exceptionState));
jsKeyframes.append(Dictionary(keyframe3, m_isolate, exceptionState));
- EffectInput::convert(element.get(), jsKeyframes, exceptionState);
+ EffectInput::convert(element.get(), jsKeyframes, exceptionState, true);
EXPECT_TRUE(exceptionState.hadException());
EXPECT_EQ(InvalidModificationError, exceptionState.code());
}
« Source/core/animation/EffectInput.cpp ('K') | « Source/core/animation/EffectInput.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698