Resolve style in element.animate()

Source/core/animation/EffectInput.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 171 matching lines @@
 
     auto iter = supportedAttributes.find(attributeName);
     if (iter == supportedAttributes.end() || !svgElement->propertyFromAttribute(*iter->value))
         return nullptr;
 
     return iter->value;
 }
 
 } // namespace
 
-PassRefPtrWillBeRawPtr<EffectModel> EffectInput::convert(Element* element, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState& exceptionState)
+PassRefPtrWillBeRawPtr<EffectModel> EffectInput::convert(Element* element, const Vector<Dictionary>& keyframeDictionaryVector, ExceptionState& exceptionState, bool unsafe)
 {
-    // FIXME: Remove the dependency on element.
     if (!element)
         return nullptr;
 
+    // TODO(alancutter): Remove this once composited animations no longer depend on AnimatableValues.
+    if (!unsafe) {
+        if (!element->inActiveDocument())

[esprehn, 2015/06/04 06:18:09]

This unsafe thing just for unit tests seems bad, the unit tests should put the
element into an active document. Indeed even
StyleResolver::createAnimatableValueSnapshot tries to use the document, and
those methods shouldn't be static...

+            return nullptr;
+        element->document().updateLayoutTreeForNodeIfNeeded(element);
+    }
+
     StyleSheetContents* styleSheetContents = element->document().elementSheet().contents();
     StringKeyframeVector keyframes;
     double lastOffset = 0;
 
     for (const auto& keyframeDictionary : keyframeDictionaryVector) {
         RefPtrWillBeRawPtr<StringKeyframe> keyframe = StringKeyframe::create();
 
         ScriptValue scriptValue;
         bool frameHasOffset = DictionaryHelper::get(keyframeDictionary, "offset", scriptValue) && !scriptValue.isNull();
 
@@ skipping 78 matching lines @@
 PassRefPtrWillBeRawPtr<EffectModel> EffectInput::convert(Element* element, const EffectModelOrDictionarySequence& effectInput, ExceptionState& exceptionState)
 {
     if (effectInput.isEffectModel())
         return effectInput.getAsEffectModel();
     if (effectInput.isDictionarySequence())
         return convert(element, effectInput.getAsDictionarySequence(), exceptionState);
     return nullptr;
 }
 
 } // namespace blink