Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: Source/core/svg/SVGFilterElement.cpp

Issue 1153403003: Remove SVGFilterElement's filterRes* attributes and setFilterRes() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase + updated smallFonts.svg and textFeatures.svg Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGFilterElement.h ('k') | Source/core/svg/SVGFilterElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFilterElement.cpp
diff --git a/Source/core/svg/SVGFilterElement.cpp b/Source/core/svg/SVGFilterElement.cpp
index f997d820869e5e46c77fa6682fd9c4b0006e3e15..e1ead448be9499c660d21d0f4aebb5e50c78f648 100644
--- a/Source/core/svg/SVGFilterElement.cpp
+++ b/Source/core/svg/SVGFilterElement.cpp
@@ -41,7 +41,6 @@ inline SVGFilterElement::SVGFilterElement(Document& document)
, m_height(SVGAnimatedLength::create(this, SVGNames::heightAttr, SVGLength::create(SVGLengthMode::Height), ForbidNegativeLengths))
, m_filterUnits(SVGAnimatedEnumeration<SVGUnitTypes::SVGUnitType>::create(this, SVGNames::filterUnitsAttr, SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX))
, m_primitiveUnits(SVGAnimatedEnumeration<SVGUnitTypes::SVGUnitType>::create(this, SVGNames::primitiveUnitsAttr, SVGUnitTypes::SVG_UNIT_TYPE_USERSPACEONUSE))
- , m_filterRes(SVGAnimatedIntegerOptionalInteger::create(this, SVGNames::filterResAttr))
{
// Spec: If the x/y attribute is not specified, the effect is as if a value of "-10%" were specified.
// Spec: If the width/height attribute is not specified, the effect is as if a value of "120%" were specified.
@@ -56,7 +55,6 @@ inline SVGFilterElement::SVGFilterElement(Document& document)
addToPropertyMap(m_height);
addToPropertyMap(m_filterUnits);
addToPropertyMap(m_primitiveUnits);
- addToPropertyMap(m_filterRes);
}
DEFINE_NODE_FACTORY(SVGFilterElement)
@@ -70,22 +68,12 @@ DEFINE_TRACE(SVGFilterElement)
visitor->trace(m_height);
visitor->trace(m_filterUnits);
visitor->trace(m_primitiveUnits);
- visitor->trace(m_filterRes);
visitor->trace(m_clientsToAdd);
#endif
SVGElement::trace(visitor);
SVGURIReference::trace(visitor);
}
-void SVGFilterElement::setFilterRes(unsigned x, unsigned y)
-{
- filterResX()->baseValue()->setValue(x);
- filterResY()->baseValue()->setValue(y);
-
- invalidateSVGAttributes();
- svgAttributeChanged(SVGNames::filterResAttr);
-}
-
void SVGFilterElement::svgAttributeChanged(const QualifiedName& attrName)
{
bool isXYWH = attrName == SVGNames::xAttr
@@ -94,11 +82,8 @@ void SVGFilterElement::svgAttributeChanged(const QualifiedName& attrName)
|| attrName == SVGNames::heightAttr;
if (isXYWH)
updateRelativeLengthsInformation();
- else if (attrName == SVGNames::filterResAttr)
- UseCounter::count(document(), UseCounter::SVGFilterRes);
if (isXYWH
- || attrName == SVGNames::filterResAttr
|| attrName == SVGNames::filterUnitsAttr
|| attrName == SVGNames::primitiveUnitsAttr) {
SVGElement::InvalidationGuard invalidationGuard(this);
« no previous file with comments | « Source/core/svg/SVGFilterElement.h ('k') | Source/core/svg/SVGFilterElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698