Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: LayoutTests/svg/dom/script-tests/SVGAnimatedInteger.js

Issue 1153403003: Remove SVGFilterElement's filterRes* attributes and setFilterRes() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase + updated smallFonts.svg and textFeatures.svg Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/svg/dom/script-tests/SVGAnimatedInteger.js
diff --git a/LayoutTests/svg/dom/script-tests/SVGAnimatedInteger.js b/LayoutTests/svg/dom/script-tests/SVGAnimatedInteger.js
index 7756ec716599eb0ed230bf82602b12bad93d1d0b..9c63af05d24ed99cf685c9ebdc5a7ecf325166f4 100644
--- a/LayoutTests/svg/dom/script-tests/SVGAnimatedInteger.js
+++ b/LayoutTests/svg/dom/script-tests/SVGAnimatedInteger.js
@@ -1,33 +1,33 @@
-description("This test checks the SVGAnimatedInteger API - utilizing the filterResX property of SVGFilterElement");
+description("This test checks the SVGAnimatedInteger API - utilizing the targetX property of SVGFEConvolveMatrix");
-var filterElement = document.createElementNS("http://www.w3.org/2000/svg", "filter");
+var feConvolveMatrix = document.createElementNS("http://www.w3.org/2000/svg", "feConvolveMatrix");
debug("");
-debug("Check initial filterResX value");
-shouldBeEqualToString("filterElement.filterResX.toString()", "[object SVGAnimatedInteger]");
-shouldBeEqualToString("typeof(filterElement.filterResX.baseVal)", "number");
-shouldBe("filterElement.filterResX.baseVal", "0");
+debug("Check initial targetX value");
+shouldBeEqualToString("feConvolveMatrix.targetX.toString()", "[object SVGAnimatedInteger]");
+shouldBeEqualToString("typeof(feConvolveMatrix.targetX.baseVal)", "number");
+shouldBe("feConvolveMatrix.targetX.baseVal", "0");
debug("");
debug("Check that integers are static, caching value in a local variable and modifying it, should have no effect");
-var numRef = filterElement.filterResX.baseVal;
+var numRef = feConvolveMatrix.targetX.baseVal;
numRef = 100;
shouldBe("numRef", "100");
-shouldBe("filterElement.filterResX.baseVal", "0");
+shouldBe("feConvolveMatrix.targetX.baseVal", "0");
debug("");
debug("Check assigning various valid and invalid values");
-shouldBe("filterElement.filterResX.baseVal = -1", "-1"); // Negative values are allowed from SVG DOM, but should lead to an error when rendering (disable the filter)
-shouldBe("filterElement.filterResX.baseVal = 300", "300");
+shouldBe("feConvolveMatrix.targetX.baseVal = -1", "-1"); // Negative values are allowed from SVG DOM, but should lead to an error when rendering (disable the filter)
+shouldBe("feConvolveMatrix.targetX.baseVal = 300", "300");
// ECMA-262, 9.5, "ToInt32"
-shouldBe("filterElement.filterResX.baseVal = 'aString'", "'aString'");
-shouldBe("filterElement.filterResX.baseVal", "0");
-shouldBe("filterElement.filterResX.baseVal = filterElement", "filterElement");
-shouldBe("filterElement.filterResX.baseVal", "0");
-shouldBe("filterElement.filterResX.baseVal = 300", "300");
+shouldBe("feConvolveMatrix.targetX.baseVal = 'aString'", "'aString'");
+shouldBe("feConvolveMatrix.targetX.baseVal", "0");
+shouldBe("feConvolveMatrix.targetX.baseVal = feConvolveMatrix", "feConvolveMatrix");
+shouldBe("feConvolveMatrix.targetX.baseVal", "0");
+shouldBe("feConvolveMatrix.targetX.baseVal = 300", "300");
debug("");
-debug("Check that the filterResX value remained 300");
-shouldBe("filterElement.filterResX.baseVal", "300");
+debug("Check that the targetX value remained 300");
+shouldBe("feConvolveMatrix.targetX.baseVal", "300");
successfullyParsed = true;

Powered by Google App Engine
This is Rietveld 408576698