Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(35)

Issue 1153403003: Remove SVGFilterElement's filterRes* attributes and setFilterRes() (Closed)

Created:
4 years, 11 months ago by pdr.
Modified:
4 years, 11 months ago
Reviewers:
chrishtr, philipj_slow, fs
CC:
darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-paint_chromium.org, Inactive, dshwang, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, slimming-paint-reviews_chromium.org, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove SVGFilterElement's filterRes* attributes and setFilterRes() This patch removes filterRes per the following discussion on blink-dev: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o0i2UtqOApY/d7i_1akVwa8J The C++ side of this patch is a straightforward code removal. Where possible, tests have been updated to use FEConvolveMatrix.targetX for testing SVGAnimatableInteger values. Tests with just filterRes have been removed. BUG=353272 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196268

Patch Set 1 #

Patch Set 2 : Rebase + updated smallFonts.svg and textFeatures.svg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -672 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js View 2 chunks +0 lines, -3 lines 0 comments Download
D LayoutTests/animations/svg-attribute-interpolation/svg-filterRes-interpolation.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/animations/svg-attribute-interpolation/svg-filterRes-interpolation-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/html5lib/resources/tests11.dat View 8 chunks +4 lines, -8 lines 0 comments Download
D LayoutTests/platform/android/svg/filters/filterRes-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/svg/filters/filterRes2-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/virtual/slimmingpaint/svg/filters/filterRes-expected.png View Binary file 0 comments Download
M LayoutTests/platform/android/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/platform/android/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/platform/mac/svg/filters/filterRes1-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/svg/filters/filterRes3-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/platform/win/svg/filters/filterRes1-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/svg/filters/filterRes3-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/W3C-SVG-1.1/resources/SVG-1.1-monolithic-fixed.dtd View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/resources-svgdom-invalidation-crash.svg View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/dom/SVGAnimatedInteger-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M LayoutTests/svg/dom/script-tests/SVGAnimatedInteger.js View 1 chunk +17 lines, -17 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-dom-filterRes-attr.js View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterRes-call.js View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResX-prop.js View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResY-prop.js View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/svg/filters/filterRes.svg View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/svg/filters/filterRes-expected.png View Binary file 0 comments Download
D LayoutTests/svg/filters/filterRes-expected.txt View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/svg/filters/filterRes1.svg View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/svg/filters/filterRes1-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/svg/filters/filterRes2.svg View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/svg/filters/filterRes2-expected.png View Binary file 0 comments Download
D LayoutTests/svg/filters/filterRes2-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/svg/filters/filterRes3.svg View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/svg/filters/filterRes3-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/virtual/slimmingpaint/svg/filters/filterRes-expected.png View Binary file 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -3 lines 0 comments Download
M PerformanceTests/Parser/resources/html5.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/EffectInput.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/paint/SVGFilterPainter.cpp View 1 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/svg/SVGAttributeNames.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.h View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 4 chunks +0 lines, -15 lines 0 comments Download
M Source/core/svg/SVGFilterElement.idl View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
pdr.
4 years, 11 months ago (2015-06-01 15:42:08 UTC) #2
chrishtr
lgtm
4 years, 11 months ago (2015-06-01 15:58:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153403003/1
4 years, 11 months ago (2015-06-01 15:58:45 UTC) #5
fs
lgtm
4 years, 11 months ago (2015-06-01 16:01:33 UTC) #6
pdr.
This patch is failing because two tests (smallFonts.svg, textFeatures.svg) used filterRes and now have pixel ...
4 years, 11 months ago (2015-06-01 16:45:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64191)
4 years, 11 months ago (2015-06-01 18:09:32 UTC) #9
philipj_slow
Also LGTM, red diffs are the best diffs!
4 years, 11 months ago (2015-06-01 18:15:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153403003/40001
4 years, 11 months ago (2015-06-01 23:33:50 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 01:27:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196268

Powered by Google App Engine
This is Rietveld 408576698