Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1153393007: Fix assert on Mandoline shutdown. (Closed)

Created:
5 years, 6 months ago by jam
Modified:
5 years, 6 months ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix assert on Mandoline shutdown. Committed: https://crrev.com/f917affc6efda9d5368506cd43c063338d8544d5 Cr-Commit-Position: refs/heads/master@{#332881}

Patch Set 1 #

Total comments: 4

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M mandoline/tab/frame.h View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/tab/frame.cc View 1 2 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
jam
Not really familiar with this code, so this is more of an attempt.
5 years, 6 months ago (2015-06-04 03:04:25 UTC) #2
Fady Samuel
https://codereview.chromium.org/1153393007/diff/1/mandoline/tab/frame.cc File mandoline/tab/frame.cc (right): https://codereview.chromium.org/1153393007/diff/1/mandoline/tab/frame.cc#newcode91 mandoline/tab/frame.cc:91: if (tree_->root() == this) { Alternatively, FrameTree could hold ...
5 years, 6 months ago (2015-06-04 03:21:45 UTC) #4
sky
Can the browser destroy the frametree before we get here?
5 years, 6 months ago (2015-06-04 03:38:00 UTC) #5
jam
On 2015/06/04 03:38:00, sky wrote: > Can the browser destroy the frametree before we get ...
5 years, 6 months ago (2015-06-04 03:51:31 UTC) #6
sky
What is the flow of shutdown now? Is it keyed off the ViewManager going away? ...
5 years, 6 months ago (2015-06-04 04:22:58 UTC) #7
sky
LGTM https://codereview.chromium.org/1153393007/diff/1/mandoline/tab/frame.cc File mandoline/tab/frame.cc (right): https://codereview.chromium.org/1153393007/diff/1/mandoline/tab/frame.cc#newcode92 mandoline/tab/frame.cc:92: view_ = nullptr; view_->RemoveObserver(this) before the return
5 years, 6 months ago (2015-06-04 19:17:50 UTC) #8
jam
https://codereview.chromium.org/1153393007/diff/1/mandoline/tab/frame.cc File mandoline/tab/frame.cc (right): https://codereview.chromium.org/1153393007/diff/1/mandoline/tab/frame.cc#newcode92 mandoline/tab/frame.cc:92: view_ = nullptr; On 2015/06/04 19:17:50, sky wrote: > ...
5 years, 6 months ago (2015-06-04 19:20:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153393007/20001
5 years, 6 months ago (2015-06-04 19:22:07 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-04 19:37:29 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 19:38:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f917affc6efda9d5368506cd43c063338d8544d5
Cr-Commit-Position: refs/heads/master@{#332881}

Powered by Google App Engine
This is Rietveld 408576698