Issue 1153343004: Mark fn2's EventListenerNode work for PointerEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153343004: Mark fn2's EventListenerNode work for PointerEvent (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
eseidel

CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Mark fn2's EventListenerNode work for PointerEvent Prevously we listened for events on the document and then walked up the component hierarchy looking for EventListenerNodes. Now we do something similar by hooking the event dispatching logic in the AppView. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a59c8cb9df0abf9941546cf7e0d4d04a760991d4

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -37 lines)			Patch
A	sky/examples/fn2/container.dart	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/app.dart	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	sky/sdk/lib/framework/fn2.dart	View	4 chunks	+22 lines, -33 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/1153343004/diff/1/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (right): https://codereview.chromium.org/1153343004/diff/1/sky/sdk/lib/framework/fn2.dart#newcode873 sky/sdk/lib/framework/fn2.dart:873: class _AppView extends AppView { FnAppView?

5 years, 6 months ago (2015-06-02 19:12:47 UTC) #2

abarth-chromium

5 years, 6 months ago (2015-06-02 19:18:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a59c8cb9df0abf9941546cf7e0d4d04a760991d4 (presubmit successful).

Expand Messages | Collapse Messages