Fix painting bounds calculations for ellipsis

Fix painting bounds calculations for ellipsis

Change the paint bounds computation, to base it on logical bounds and
then apply a logical -> physical transform. Include the selection rect
if needed.

TEST=fast/css/text-overflow-ellipsis-vertical-select.html (S.P. strict cull)
BUG=496318
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196592

[fs, 2015-06-05 15:33:43]

fs@opera.com changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2015-06-05 16:46:06]

https://codereview.chromium.org/1153333005/diff/1/Source/core/paint/EllipsisB...
File Source/core/paint/EllipsisBoxPainter.cpp (right):

https://codereview.chromium.org/1153333005/diff/1/Source/core/paint/EllipsisB...
Source/core/paint/EllipsisBoxPainter.cpp:26: bool isPrinting =
m_ellipsisBox.layoutObject().document().printing();
EllipsisBox inherits from InlineBox. Can you leverage the same techique you're
using in https://codereview.chromium.org/1163913002?

Does that other CL need selection bounds?

[fs, 2015-06-05 17:14:03]

https://codereview.chromium.org/1153333005/diff/1/Source/core/paint/EllipsisB...
File Source/core/paint/EllipsisBoxPainter.cpp (right):

https://codereview.chromium.org/1153333005/diff/1/Source/core/paint/EllipsisB...
Source/core/paint/EllipsisBoxPainter.cpp:26: bool isPrinting =
m_ellipsisBox.layoutObject().document().printing();
On 2015/06/05 16:46:06, chrishtr wrote:
> EllipsisBox inherits from InlineBox. Can you leverage the same techique you're
> using in https://codereview.chromium.org/1163913002

I don't see how I could - InlineBox (this CL) vs. LayoutInline/LayoutObject
(that CL) - or di you mean another CL?

> Does that other CL need selection bounds?

It only deals with outline/focus ring painting (w/ separate recorders) so I
don't see that it would. Selections there would be painted by
InlineTextBoxPainter I guess.

[chrishtr, 2015-06-05 17:31:06]

On 2015/06/05 at 17:14:03, fs wrote:
>
https://codereview.chromium.org/1153333005/diff/1/Source/core/paint/EllipsisB...
> File Source/core/paint/EllipsisBoxPainter.cpp (right):
> 
>
https://codereview.chromium.org/1153333005/diff/1/Source/core/paint/EllipsisB...
> Source/core/paint/EllipsisBoxPainter.cpp:26: bool isPrinting =
m_ellipsisBox.layoutObject().document().printing();
> On 2015/06/05 16:46:06, chrishtr wrote:
> > EllipsisBox inherits from InlineBox. Can you leverage the same techique
you're
> > using in https://codereview.chromium.org/1163913002
> 
> I don't see how I could - InlineBox (this CL) vs. LayoutInline/LayoutObject
(that CL) - or di you mean another CL?
> 
> > Does that other CL need selection bounds?
> 
> It only deals with outline/focus ring painting (w/ separate recorders) so I
don't see that it would. Selections there would be painted by
InlineTextBoxPainter I guess.

Oops, sorry about that. Forget my comment.

[chrishtr, 2015-06-05 17:47:23]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-06-05 17:47:24]

lgtm

[commit-bot: I haz the power, 2015-06-05 17:47:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1153333005/1

[commit-bot: I haz the power, 2015-06-05 17:52:05]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196592