Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1153333003: Added tools to retrieve CQ builders from a CQ config (Closed)

Created:
5 years, 6 months ago by Sergiy Byelozyorov
Modified:
5 years, 6 months ago
Reviewers:
pgervais
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Added tools to retrieve CQ builders from a CQ config R=pgervais@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295461

Patch Set 1 #

Patch Set 2 : Changed output format a bit to include custom properties #

Total comments: 2

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11095 lines, --2 lines) Patch
M commit_queue.py View 1 2 3 chunks +46 lines, -0 lines 0 comments Download
A + third_party/cq_client/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
A third_party/cq_client/cq.proto View 1 chunk +163 lines, -0 lines 0 comments Download
A third_party/cq_client/cq_pb2.py View 1 chunk +580 lines, -0 lines 0 comments Download
A third_party/google/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/google/protobuf/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/google/protobuf/compiler/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/google/protobuf/compiler/plugin_pb2.py View 1 chunk +184 lines, -0 lines 0 comments Download
A third_party/google/protobuf/descriptor.py View 1 chunk +849 lines, -0 lines 0 comments Download
A third_party/google/protobuf/descriptor_database.py View 1 chunk +137 lines, -0 lines 0 comments Download
A third_party/google/protobuf/descriptor_pb2.py View 1 chunk +1522 lines, -0 lines 0 comments Download
A third_party/google/protobuf/descriptor_pool.py View 1 chunk +643 lines, -0 lines 0 comments Download
A + third_party/google/protobuf/internal/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/google/protobuf/internal/api_implementation.py View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/google/protobuf/internal/containers.py View 1 chunk +269 lines, -0 lines 0 comments Download
A third_party/google/protobuf/internal/cpp_message.py View 1 chunk +663 lines, -0 lines 0 comments Download
A third_party/google/protobuf/internal/decoder.py View 1 chunk +831 lines, -0 lines 0 comments Download
A third_party/google/protobuf/internal/encoder.py View 1 chunk +788 lines, -0 lines 0 comments Download
A third_party/google/protobuf/internal/enum_type_wrapper.py View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/google/protobuf/internal/message_listener.py View 1 chunk +78 lines, -0 lines 0 comments Download
A third_party/google/protobuf/internal/python_message.py View 1 chunk +1247 lines, -0 lines 0 comments Download
A third_party/google/protobuf/internal/type_checkers.py View 1 chunk +328 lines, -0 lines 0 comments Download
A third_party/google/protobuf/internal/wire_format.py View 1 chunk +268 lines, -0 lines 0 comments Download
A third_party/google/protobuf/message.py View 1 chunk +284 lines, -0 lines 0 comments Download
A third_party/google/protobuf/message_factory.py View 1 chunk +155 lines, -0 lines 0 comments Download
A third_party/google/protobuf/reflection.py View 1 chunk +205 lines, -0 lines 0 comments Download
A third_party/google/protobuf/service.py View 1 chunk +226 lines, -0 lines 0 comments Download
A third_party/google/protobuf/service_reflection.py View 1 chunk +284 lines, -0 lines 0 comments Download
A third_party/google/protobuf/symbol_database.py View 1 chunk +185 lines, -0 lines 0 comments Download
A third_party/google/protobuf/text_encoding.py View 1 chunk +110 lines, -0 lines 0 comments Download
A third_party/google/protobuf/text_format.py View 1 chunk +873 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sergiy Byelozyorov
5 years, 6 months ago (2015-05-29 16:56:47 UTC) #1
pgervais
lgtm I would just add a README file to tell where cq_client comes from, and ...
5 years, 6 months ago (2015-05-29 17:01:09 UTC) #2
Sergiy Byelozyorov
https://codereview.chromium.org/1153333003/diff/20001/commit_queue.py File commit_queue.py (right): https://codereview.chromium.org/1153333003/diff/20001/commit_queue.py#newcode130 commit_queue.py:130: parser.error('Expected a path to CQ config. Got: %s' % ...
5 years, 6 months ago (2015-05-29 17:04:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153333003/40001
5 years, 6 months ago (2015-05-29 17:05:45 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 17:09:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295461

Powered by Google App Engine
This is Rietveld 408576698