Issue 1153313005: tweak build_sdk to display color unified diffs, and move diff to after the build succeeds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153313005: tweak build_sdk to display color unified diffs, and move diff to after the build succeeds (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly

Modified:
5 years, 6 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

tweak build_sdk to display color unified diffs, and move diff to after the build succeeds when debugging js_codegen errors, this makes it a lot easier to see the stack trace. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/c4168261c1fd18c4eed6ebec2775c876384e3f53

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
	M	tool/build_sdk.sh	View		1 chunk	+12 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

I tested this out in a couple of permutations. It makes diff failures show up ...

5 years, 6 months ago (2015-05-29 22:15:20 UTC) #2

Jennifer Messerly

5 years, 6 months ago (2015-05-29 22:47:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c4168261c1fd18c4eed6ebec2775c876384e3f53 (presubmit successful).