Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 11533014: Merge 172232 (Closed)

Created:
8 years ago by akalin
Modified:
8 years ago
Reviewers:
akalin
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Merge 172232 > [Sync] Handle invalid specifics field numbers gracefully > > Change GetModelTypeFromSpecificsFieldNumber() to not NOTREACHED() on an > unknown field number. Instead, have callers compare the return value > to UNSPECIFIED and handle that case. > > BUG=165171 > > > Review URL: https://chromiumcodereview.appspot.com/11490018 TBR=akalin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -14 lines) Patch
M sync/engine/store_timestamps_command.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M sync/engine/syncer_proto_util.cc View 2 chunks +15 lines, -5 lines 0 comments Download
M sync/internal_api/public/base/model_type.h View 1 chunk +19 lines, -1 line 0 comments Download
M sync/syncable/model_type.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/syncable/model_type_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
akalin
8 years ago (2012-12-11 20:19:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698