Issue 1153293004: Improve GaiaAuthFetcher's API for its subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153293004: Improve GaiaAuthFetcher's API for its subclasses. (Closed)

Created:
5 years, 6 months ago by bzanotti

Modified:
5 years, 6 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Improve GaiaAuthFetcher's API for its subclasses. As |GaiaAuthFetcher::CreateAndStartGaiaFetcher| can already be specialized by a subclass, |GaiaAuthFetcher::CancelRequest| should as well, to allow specialized fetchers to be cancelled. BUG=495597 Committed: https://crrev.com/6b49663d722eb516fbe96ae6f64d5bfc48a1dd57 Cr-Commit-Position: refs/heads/master@{#333045}

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	google_apis/gaia/gaia_auth_fetcher.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	google_apis/gaia/gaia_auth_fetcher.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153293004/1

5 years, 6 months ago (2015-06-05 13:19:13 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 14:45:07 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6b49663d722eb516fbe96ae6f64d5bfc48a1dd57
Cr-Commit-Position: refs/heads/master@{#333045}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages