Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: chrome/test/data/nacl/gdb_rsp.py

Issue 1153293003: NaCl cleanup: Stop connecting to the SRPC trusted command channel (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Remove uncalled OnChannelError() Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/nacl/debug_stub_browser_tests.py ('k') | components/nacl/loader/nacl_trusted_listener.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/nacl/gdb_rsp.py
diff --git a/chrome/test/data/nacl/gdb_rsp.py b/chrome/test/data/nacl/gdb_rsp.py
index 28680df0dfc9a6077feffe6a46aa70f4cfa31bbc..7882517a337909b7b59bb8cdf8205fcd1337a33f 100644
--- a/chrome/test/data/nacl/gdb_rsp.py
+++ b/chrome/test/data/nacl/gdb_rsp.py
@@ -16,6 +16,11 @@ def RspChecksum(data):
return checksum
+class EofOnReplyException(Exception):
+
bradn 2015/06/11 19:51:59 extra line?
Mark Seaborn 2015/06/11 20:05:11 Well, it's consistent with "One blank line between
+ pass
+
+
class GdbRspConnection(object):
def __init__(self, addr):
@@ -47,6 +52,8 @@ class GdbRspConnection(object):
while True:
data = self._socket.recv(1024)
if len(data) == 0:
+ if reply == '+':
+ raise EofOnReplyException()
raise AssertionError('EOF on socket reached with '
'incomplete reply message: %r' % reply)
reply += data
« no previous file with comments | « chrome/test/data/nacl/debug_stub_browser_tests.py ('k') | components/nacl/loader/nacl_trusted_listener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698